22598 - No access to document from a plugin

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, enhancement, P3)

Description

[av (gone)]

Current plugin API does not allow to access document.

Comment 1

[av (gone)]

Proposed fix is to add a method to nsIPluginTagInfo as follows:

nsIPluginTagInfo.h

   NS_IMETHOD GetDOMElement(nsIDOMElement* *result) = 0;
==================
nsPluginInstancePeer.h

class nsPluginInstancePeerImpl
...
   NS_IMETHOD GetDOMElement(nsIDOMElement* *result);
==================
nsPluginInstancePeer.cpp

NS_IMETHODIMP nsPluginInstancePeerImpl::GetDOMElement(nsIDOMElement* *result)
{
  if (nsnull != mOwner)
  {
    nsIPluginTagInfo  *tinfo;
    nsresult          rv;

    rv = mOwner->QueryInterface(kIPluginTagInfoIID, (void **)&tinfo);

    if (NS_OK == rv)
    {
      rv = tinfo->GetDOMElement(result);
      NS_RELEASE(tinfo);
    }

    return rv;
  }
  else
  {
    *result = nsnull;
    return NS_ERROR_FAILURE;
  }
}
==================
nsObjectFrame.cpp

class nsPluginInstanceOwner
...
  NS_IMETHOD GetDOMElement(nsIDOMElement* *result);
...
NS_IMETHODIMP nsPluginInstanceOwner::GetDOMElement(nsIDOMElement* *result)
{
  nsresult rv = NS_ERROR_FAILURE;

  *result = nsnull;

  if (nsnull != mOwner)
  {
    nsIContent  *cont;

    mOwner->GetContent(&cont);

    if (nsnull != cont)
    {
      rv = cont->QueryInterface(nsIDOMElement::GetIID(), (void **)result);
      NS_RELEASE(cont);
    }
  }
  return rv;
}

Comment 2

[av (gone)]

Checked in.

Comment 3

[shrirang khanzode]

Andrei, please mark this bug as VERIFIED.