226076 - [RR]Incorrect text line spacing when changing stylesheet for a web page

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Phillip Wright]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7

Line spacing (or perhaps line height) can become bad when changing from large
fonts to smaller fonts by switching the stylesheet.
This is best seen on the the exampple URL provided with the bug
(http://www.mozilla.org/docs/tutorials/tinderstatus/)
When switching from a large font stylesheet to a smaller font style sheet, it
appears that the height of each line remains the same as it was for the larger
font size, while the font is (correctly) displayed smaller, giving the
impression that there is additional spacing between the lines.

Reproducible: Always

Steps to Reproduce:
1. Load http://www.mozilla.org/docs/tutorials/tinderstatus/
2. Use the stylesheet selection control at the bottom left of the browser to
change to the "largefonts" stylesheet
3. Use the stylesheet selection control at the bottom left of the browser to
change to the "default" stylesheet

Actual Results:  
When changing from the "largefonts" stylesheet to the "default" stylesheet, the
text on the page is correctly resized according to the new stylesheet. However,
the height of each text line remains the same as it was for the previously
displayed large fonts, which appears as extra space between each line of text.
Also, in the main area of the example age is a link to "Linky" - when the cursor
is hovered over the link, the link text changes colour and is underlined,
however the underline is drawn too high and looks almost like a strike-through.
Lastly, this same "Linky" link is drawn in thw wrong place on the page - it
appears as if it has retained its previous coordinate position for the place
where it was displayed when the largefont stylesheet was selected. This results
in there being a rather large white space just before the link text.
Actually, one more thing I just noticed - the text wrapping is not
"recalculated", ie all line breaks appear as they did for the large font size
stylesheet.

Expected Results:  
The line height should have been updated with the new font size

If the in-browser text size controls are used after reproducing the defect (eg
ctrl + "+", ctrl + "-"), the defect disappears - ie the line height appears to
be displayed correctly.
Further, if the mouse is hovered over links in the left hand nav area on the
example page, the height of the line of text containing the link is displayed
correctly.

Comment 1

[Bill Mason]

->Browser/Layout

Comment 2

[Boris Zbarsky [:bzbarsky]]

Any chance of a smallish testcase?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

FWIW, it's pretty clear that the problem isn't in ReResolve itself but in the
style changed reflow not propagating correctly.  I wonder if we propagate style
changed reflows to out-of-flow descendants at all...

Comment 4

[Boris Zbarsky [:bzbarsky]]

I think we don't in many cases... we have lots of existing bugs on that with abs
and fixed positioned frames.  See the dependencies of bug 170644 (and bug 170644
comment 10 in particular).

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 226500 has been marked as a duplicate of this bug. ***

Comment 6

[Boris Zbarsky [:bzbarsky]]

The page doesn't seem to have alternate sheets anymore...

Comment 7

[Boris Zbarsky [:bzbarsky]]

Is this still a problem?  Please test with builds from tomorrow (May 5, 2004) or
later.

Comment 8

[Jason Barnabe (np)]

Page changed and no longer exhibits bug. Marking invalid.