226119 - Rename misnamed template admin/add-group

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Jouni Heikniemi]

Per discussion raised on reviewers@, the naming of template
admin/add-group.html.tmpl is suboptimal for the future. When editgroups get
further templatized, we will have more group-related stuff. For this purpose,
admin/groups directory will be necessary. Also, Myk pointed out that "create" is
a better term for adding new stuff, and that repeating the noun ("group") is not
necessary. Therefore, the template should be renamed to
admin/groups/create.html.tmpl.

Comment 1

[Jouni Heikniemi]

Attachment: v1

This is technically trivial; in addition to the change presented, the template
will be moved and renamed.

Comment 2

[Jouni Heikniemi]

Comment on attachment 135828 [details] [diff] [review]
v1

Myk, can you r=/a= this since it's originally reviewed and approved by you and
you're the origin of the guidelines for this stuff?

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 135828 [details] [diff] [review]
v1

r=myk.	What's the strategy for moving the template?  Are we going to copy the
file in CVS and then CVS remove the old one?

Comment 4

[Vlad Dascalu]

That's one solution. The other one would be to get someone with direct access to
the CVS repository and tweak the entries for us in order to keep the history of
the original commit, but that's pretty much a hack. :)

Comment 5

[Dave Miller [:justdave]]

we could do that (comment 3 and comment 4 are both suggesting the same thing ;)

I'm not too concerned about losing it if it's only a week old.

Comment 6

[Jouni Heikniemi]

I was originally considering a simple cvs rm / cvs add with a good descriptive
comment (stating both new and old filenames) since we only have a whopping one
revision of history to lose.

But whatever you're ready to go with.

Comment 7

[Dave Miller [:justdave]]

go for it.

Comment 8

[Jouni Heikniemi]

Checking in editgroups.cgi;
/cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v  <--  editgroups.cgi
new revision: 1.31; previous revision: 1.30
done
Removing template/en/default/admin/add-group.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/add-group.html.tmpl,v
 <--  add-group.html.tmpl
new revision: delete; previous revision: 1.1
done
RCS file:
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/create.html.tmpl,v
done
Checking in template/en/default/admin/groups/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/create.html.tmpl,v
 <--  create.html.tmpl
initial revision: 1.1
done