The default bug view has changed. See this FAQ.

Fix filenames for mozilla help to follow readme-style

RESOLVED FIXED in seamonkey2.1a2

Status

SeaMonkey
Help Documentation
RESOLVED FIXED
14 years ago
7 years ago

People

(Reporter: timeless, Assigned: rickiees)

Tracking

Trunk
seamonkey2.1a2

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
I was reviewing a patch for rjk and noticed that help uses both - and _ in
filenames. This sucks :). I said that I thought we should only use -, I was
right. Please fix.

Comment 1

14 years ago
Accepting

Comment 2

14 years ago
Keller, can we hold this? After we update and convert all files to .xhtml , we
should start reorganizing and breaking up the content into smaller files. Then
we can fix the filenames.

Comment 3

14 years ago
of course, I was thinking the same thing.

Updated

13 years ago
Assignee: rlk → nobody
Status: ASSIGNED → NEW

Updated

10 years ago
Component: Help Viewer → Help
Product: Documentation → Mozilla Application Suite
Version: unspecified → Trunk

Comment 4

8 years ago
MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614
Status: NEW → UNCONFIRMED

Comment 5

7 years ago
The files we need to worry about are:
shortcuts-composer.xhtml
shortcuts-mailnews.xhtml
shortcuts-navigator.xhtml
The rest can wait until bug 130733 is fixed.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: helpwanted
QA Contact: danielwang → help
(Assignee)

Comment 6

7 years ago
Based on comment 5, fixing this seems almost trivial. Apparently, only four files contain the sequence "shortcuts-" (in comm-central):

shortcuts.xhtml
help-index1.rdf
suite-toc.rdf
customize_help.xhtml

Is it OK if give it a try?

Comment 7

7 years ago
Yes, please. Don't forget /suite/locales/jar.mn
Use hg rename to keep the history of the shortcut-* files
(Assignee)

Comment 8

7 years ago
Created attachment 448411 [details] [diff] [review]
First try to fix filenames to use underscore instead of hyphen [Checkin: Comment 18]

Providing patch and taking the bug myself.
Assignee: nobody → rpmdisguise-otros
Attachment #448411 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 9

7 years ago
Actually, I've just read mozilla.org Documentation Style (the URL referenced in the bug) and I think I've done it the reverse of how it should be, because I've extended the use of underscores instead of removing them in favor of hyphens. :-? The truth is that use of underscore is dominant in help files, but I don't know if that's the case for the generality of mozilla.org repository.

Besides that, there are some files in help/images that use hyphens whereas most use underscore.
(In reply to comment #9)
> Actually, I've just read mozilla.org Documentation Style (the URL referenced in
> the bug) and I think I've done it the reverse of how it should be, because I've
> extended the use of underscores instead of removing them in favor of hyphens.

Right, according to that document and the previous comments in this bug (with the notable exception of Ian's comment 5 which got it wrong in the first place), the hyphen should be used throughout the help/ directory.

However:
1. Most files in help/ use the underscore to separate words in the file name.
2. I think the reasoning for using hyphens, which is given in the document (URL), does not apply to Help. Help links use custom link labels (is that the correct term?) instead of the name of the target file (correct me if I'm wrong).

> The truth is that use of underscore is dominant in help files, but I don't
> know if that's the case for the generality of mozilla.org repository.

I'd say the rest of the repository (or even others) is irrelevant, Help is pretty self-contained.

> Besides that, there are some files in help/images that use hyphens whereas most
> use underscore.

Well, I'm not sure starting to clean up there is worth the effort. Ian may think differently, though.

BTW: Feel free to CC me to any bugs you comment or start working on. Likewise for attachment review or feedback requests. ;-)

Comment 11

7 years ago
Hmmm, not sure how I got confused, but Jens is correct.
It is best we are consistent but as Jens said, is it worth the effort.
Yes, it would be nice to have all files using hyphen instead of underscore, but I rather effort goes into fixing help content than fixing filenames.
Any new files created or major work carried out on content should correct filenames but doing it one single patch would be too much work (both on patch generation and on reviewing).
Well, maybe I wasn't clear enough: I actually think we could take Ricardo's patch even if it contradicts the document linked in this bug and the previous comments, effectively changing all help files to match the current/de facto underscore rule. The reason for hyphenation given in the document was "underscores don't show up in underlined text" but we don't show those file names anywhere, do we?

Also my "worth the effort" comment was with respect to the image file names, not the XHTML files.
(Assignee)

Comment 13

7 years ago
I actually think both of you are saying basically the same thing. I also humbly the effort to provide a "_" -> "-" patch is too big for the win.

Comment 14

7 years ago
Comment on attachment 448411 [details] [diff] [review]
First try to fix filenames to use underscore instead of hyphen [Checkin: Comment 18]

r=me
Attachment #448411 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 15

7 years ago
(In reply to comment #14)
> (From update of attachment 448411 [details] [diff] [review])
> r=me


Could you also land the patch, please? I don't have commit rights to comm-central. :-)
(In reply to comment #15)
> Could you also land the patch, please? I don't have commit rights to
> comm-central. :-)

Just set the checkin-needed keyword and one of us will take care of that "automatically".

Updated

7 years ago
Status: NEW → ASSIGNED
Keywords: helpwanted
(Assignee)

Comment 17

7 years ago
(In reply to comment #16)
> (In reply to comment #15)
> > Could you also land the patch, please? I don't have commit rights to
> > comm-central. :-)
> 
> Just set the checkin-needed keyword and one of us will take care of that
> "automatically".


Sorry, it has been a long time since I last contributed a patch and I've forgotten the procedure. :-) Done, thank you for reminding me.
Keywords: checkin-needed

Comment 18

7 years ago
Comment on attachment 448411 [details] [diff] [review]
First try to fix filenames to use underscore instead of hyphen [Checkin: Comment 18]

http://hg.mozilla.org/comm-central/rev/7f5ea53dcf38
Attachment #448411 - Attachment description: First try to fix filenames to use underscore instead of hyphen → First try to fix filenames to use underscore instead of hyphen [Checkin: Comment 18]

Comment 19

7 years ago
Thanks for the patch :)
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a2

Comment 20

7 years ago
In case you want to do something like this in the future, doing a mass-rename of files would be pretty easy with this tool: http://fantasai.inkedblade.net/tools/about-xre
  xre 'hg rename' 's/_/-/g' *

Fixing up links in the source would be something like
  perl -pi -e '$/ = '>'; if (m/(href|src|data)="([^:]+)"/) { $uri = $2; $uri =~ tr/_/-/; s/$1="$2"/$1="$uri"/; }' *
The first statement causes Perl to split the file on '>' instead of '\n'.
The second greps for URIs.
The third and fourth create the new URI.
The fifth does the actual substitution.
You need to log in before you can comment on or make changes to this bug.