226217 - check_languages bustage

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Christian Reis]

check_languages looks at $_, which is undefined. It should really be looking at
$_[0].

Comment 1

[Christian Reis]

Attachment: kiko_v1: fix

Comment 2

[Gervase Markham [:gerv]]

So this would never have worked? Or it would have worked sometimes?

Gerv

Comment 3

[Dave Miller [:justdave]]

Based on the change, I would suspect it never worked.  Which is strange because
I could swear there were folks who tested it.

Comment 4

[Christian Reis]

Seems to have been broken when we sanitized languages in bug 199502:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/webtools/bugzilla/defparams.pl
for reference.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 135924 [details] [diff] [review]
kiko_v1: fix

r=myk

Hmm, looks like this code could be simplified by splitting on /[,\s]+/, which
would eliminate the need for trims further down in the code, ala:

    my @languages = split /[,\s+]/, trim($_[0]);
    if(!scalar(@languages)) {
       return "You need to specify a language tag."
    }
    foreach my $language (@languages) {
       if(   ! -d 'template/$language/custom' 
	  && ! -d 'template/$language/default') {

(No need to delay this patch for that, though.)

Comment 6

[Christian Reis]

Attachment: patch checked in

Comment 7

[Christian Reis]

/cvsroot/mozilla/webtools/bugzilla/defparams.pl,v  <--  defparams.pl
new revision: 1.120; previous revision: 1.119

Thanks.

Comment 8

[Tobias Burnus]

Thanks for the fix. This looks really looks like a:

schroedinbug

<jargon, programming> /shroh'din-buhg/ (MIT, from the Schroedinger's Cat
thought-experiment in quantum physics) A design or implementation bug in a
program that doesn't manifest until someone reading source or using the program
in an unusual way notices that it never should have worked, at which point the
program promptly stops working for everybody until fixed. Though (like bit rot)
this sounds impossible, it happens; some programs have harboured latent
schroedinbugs for years.

Compare heisenbug, Bohr bug, mandelbug

> Based on the change, I would suspect it never worked.  Which is strange
> because I could swear there were folks who tested it.
Hmm, I think I tested all combinations, but (see above) they didn't work.

Comment 9

[Dave Miller [:justdave]]

*** Bug 233644 has been marked as a duplicate of this bug. ***