226229 - Query.cgi HTML Transitional 4.01 validation fails for query.cgi

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Vlad Dascalu]

It appears some <br> tags added in the wrong place make query.cgi HTML
validation fail.

Comment 1

[Vlad Dascalu]

<justdave> cvsblame says that was introduced by the patch on bug 37749

Comment 2

[Antonis Christofides]

Attachment: Patch - take one

I must have entered these <br>s to make it prettier. This patch uses
style-sheets instead.

After I corrected the <br>s, the WDG HTML validator said OK, but
http://validator.w3.org/ complained about a couple of other things, which I
checked with the standard. First, the <script> tag needs to be
<script type="text/javascript">
(http://www.w3.org/TR/1999/REC-html401-19991224/interact/scripts.html#h-18.2.1).
Second, <p>
(http://www.w3.org/TR/1999/REC-html401-19991224/struct/text.html#h-9.3.1)
cannot contain block elements, and <noscript>
(http://www.w3.org/TR/1999/REC-html401-19991224/interact/scripts.html#h-18.3.1)is
a block element. This patch also corrects both these errors.

Comment 3

[Christian Reis]

Comment on attachment 136189 [details] [diff] [review]
Patch - take one

Thanks for the patch.

I'm not sure I like the bug_changes class applied to those two specific dts.
Perhaps it would be better to have something like

<dl class="bug_changes">
<dt> ...

and then use 

dl.bug_changes dt {
  ...
}

as the selector. The rest looks fine.

Comment 4

[Antonis Christofides]

Attachment: Patch - take two

Very interesting, I didn't really know. It's much better this way.

Comment 5

[Christian Reis]

Comment on attachment 136372 [details] [diff] [review]
Patch - take two

Thanks for the patch!

Comment 6

[Christian Reis]

Checked in for Anthony.

/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/form.html.tmpl,v 
<--  form.html.tmpl
new revision: 1.20; previous revision: 1.19
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search.html.tmpl,v
 <--  search.html.tmpl
new revision: 1.17; previous revision: 1.16

Comment 7

[Stewart Gordon]

It isn't valid at this time.

The version on b.m.o is only tentatively valid (missing encoding):
http://validator.w3.org/check?uri=http://bugzilla.mozilla.org/query.cgi

The one on landfill is invalid (misplaced INPUT and LABEL, unopened TR):
http://validator.w3.org/check?uri=http://landfill.bugzilla.org/bugzilla-tip/query.cgi%3Fformat%3Dadvanced

Reopening.

Comment 8

[Christian Reis]

Encoding is another issue -- bug 126266 to be precise. It might have been nicer
to open a new bug for the new search breakage, but okay.

Comment 9

[Dave Miller [:justdave]]

This has a checked in patch.  Please file a new bug.

Comment 10

[Dave Miller [:justdave]]

In fact, this bug covers both 2.18 and tip, and the problem reported in comment
7 only exists on the tip.  I filed bug 265011 to cover that.