226274 - dropmarker doesn't respond to :hover or :hover:active states

Status: RESOLVED DUPLICATE of bug 216266

(Firefox :: Toolbars and Customization, defect)

Description

[scratch]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031015 Firebird/0.7 (aebrahim)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031015 Firebird/0.7 (aebrahim)

the dropmarker on menubuttons like back and forward in the toolbar doesn't
respond to :hover or :hover:active states, as the rest of the button does.  this
means it can't be depressed, among other things.

Reproducible: Always

Steps to Reproduce:
1. add some css properties to :hover for the dropmarker in either the theme or
in userChrome.css
2. move your mouse over the dropmarker

Actual Results:  
absolutely nothing, css is ignored

Expected Results:  
css settings are applied to the dropmarker

Comment 1

[miahz]

Attachment: toolbarbutton.css updated per bug request

normally i don't use the default qute theme, so i was quite suprised when i
installed the new 0.8 and saw that this bug still hadn't been fixed.  so first
of all, i can confirm this bug - not quite sure why it has't been set so far. 
i've fixed the style so that dropmarkers hover and click properly.  as far as i
can tell, they match the "native" menu buttons on internet explorer 5 in
windows 2000 - whatever that's worth.  i don't know how to make a patch, but if
someone points me to some info, i can whip one up - unless this updated css
file is sufficient.  would like to hear from users on other OSs to make sure
everything looks ok.

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

1) you should supply a patch, not the actual file itself and 
2) won't adding a border to the dropmarker break the luna theme?

Comment 3

[scratch]

it may slightly break the luna theme a little more than it already is until
nsITheme can be corrected for buttons with dropmarkers, but the way it works now
is already kind of hack-y.  compare the way the toolbar buttons look in IE to
the way they look in Moz/FireFox with luna, they're already "broken". 
especially on the mouseovers.

Comment 4

[miahz]

Attachment: patch to fix hover states on toolbar menu buttons

ok, with some help, i figured out how to make a patch.

i assume you guys are talking about the winxp os theme luna, not the
fire[animal] theme made to look like it.  i'm on win2k and it looks ok to me,
but i have no idea how it looks on any other OS.

Comment 5

[Simon Paquet [:sipaq]]

*** Bug 235995 has been marked as a duplicate of this bug. ***

Comment 6

[Jerry Baker]

This also affects the default Firefox 0.9.1 theme.

Comment 7

[miahz]

Attachment: updated patch

Does same as previous patch, just updated to latest source - although i don't
know if the new platform-specific ___stripe themes require unique
consideration.

Can someone help out and suggest/request reviewers?  -because i have no idea
who to ask.  I'm also not strong enough to change blocking flags, and this
should almost certainly block 1.0.

Comment 8

[Sekundes]

miahz, are you going to emulate "exactly" the same as IE?
If so, I noticed there are different behaviors between them.
After applying your patch, the back button and forward button do not get hover
style when the mouse is placed on the dropmarker. However, it does so in IE.

Comment 9

[miahz]

hmm.  yeah, the dropmarker should have a hover state like IE's - it looks ok to
me in windows classic.  and i just tested in xp-luna and it looks a little
weird, but it does have a hover.  i'm pretty sure i just transferred the effect
of the old patch, but i may have messed something up.  can anyone else check this?

of course, there's several possible variations that have the same result, so if
this one isn't working, i can try another.

i'm also still not sure about different platforms (eg. the luna border breakage
that ben alluded to).  i don't know how the stylesheet rules are supposed to
play with natively-styled elements.  there's no "-moz-appearance: dropmarker".

Comment 10

[José Jeria]

This seems to be a dupe of bug 216266?

Comment 11

[Simon Paquet [:sipaq]]

Thanks Jose!

*** This bug has been marked as a duplicate of 216266 ***