226293 - JS Console is missing strict warnings (but pref is set) for XUL overlays

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect, P5)

Description

[HJ]

I installed Netscape 7.1 to check compatibility of MultiZilla v1.5.0.4C and was
shocked to find a lot of strict warnings on the JS Console. However, they are
missing from Mozilla's (build 2003111415) JS Console. What's going on?

Same pref settings, same XPI so that should be no problem.

Comment 1

[HJ]

Attachment: The missing strict warnings

This was taken from Netscape's JS Console

Comment 2

[Boris Zbarsky [:bzbarsky]]

Is "show chrome JavaScript errors and warnings" enabled in your profile (see
debug pref panel)?

Because strict JS warnings in chrome WFM in a current trunk build...

Also, which component did you mean to assign this to?  It's in Browser-General
at the moment... (see assignee and QA contact).

Comment 3

[HJ]

"Is "show chrome JavaScript errors and warnings" enabled in your profile (see
debug pref panel)?"

Do you remember that event.target.rel bug? So Yes, that's enabled and I do see
other JS Strict errors, also some of MultiZilla!

"Also, which component did you mean to assign this to?  It's in Browser-General
at the moment... (see assignee and QA contact)."

I forgot to select the right component at start but changed it to
javascript-engine, however, that didn't select the right QA Contact/Assigned To
fields and I have no clue in the new mozilla foundation world who that should
be? Do You?

Comment 4

[HJ]

I've been testing mozilla 1.4/1.5a/1.5b/1.5RC1/1.5RC-2/1.6a and the current
build but mozilla 1.4 (I skipped 1.4.1) was the last version that displayed all
my strict warnings (-:

Comment 5

[HJ]

Update: no problems with mozilla 1.4 (RC-3) and mozilla 1.4.1. but 1.5a fails to
display the strict warnings!

Comment 6

[HJ]

.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

hm, somehow the component and assignee of this bug don't really match... 

HJ: When you want to change assignee/qa contact when changing components, you
have to choose the "[x] Reassign bug to owner and QA contact of selected
component " checkbox.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Well, I can't reproduce this (I see plenty of chrome JS warnings), and there's
no testcase, so... call me when there is something to look at here (like a
testcase that can be used to reproduce or something).

Comment 9

[HJ]

I hope to reassign this bug to the right component this time.

Comment 10

[HJ]

Attachment: testcase to trigger this bug

Please include this file as no-strict-warnings.xul to navigator.xul (overlay)
and you will see what the heck I am talking about!

Comment 11

[HJ]

Steps to reprocude:
1)include the attachment as overlay to navigator.xul
2)start mozilla

Result: alert "Hi There..." but you won't see this:

Warning: function triggerBug does not always return a value
Source File: http://bugzilla.mozilla.org/attachment.cgi?id=136003&action=view
Line: 15, Column: 4
Source Code:
    }

only if you load it from the bug report.

But maybe this is just a window (NT) bug...

Comment 12

[HJ]

Attachment: Adding overlay as text file

Comment 13

[HJ]

This is limited to XUL overlays... I even used console.js/xul and
consoleBindings.xml from mozilla 1.4.1 but that didn't fix this error. 

Comment 14

[HJ]

Hmm, another thing. This is what I see in the 1.4.1. JS Console:

Warning: variable resources hides argument
Source File: chrome://multiviews/content/multiviewsRDF.js     Line: 586
  var resources = resources.replace('sm:resources:', '');

And this is what I got from menu item 'Copy':

Warning: variable resources hides argument
Source File: chrome://multiviews/content/multiviewsRDF.js
Line: 586, Column: 6
Source Code:
  var resources = resources.replace('sm:resources:', '');

I don't see 'Column: 6' and 'Source Code:' in the JS Console, but why?

Comment 15

[HJ]

This was displayed in 1.4.1
Warning: reference to undefined property this.mPanelContainer
and this in 1.6b
Warning: reference to undefined property this.mPanelContainer
Source File: chrome://global/content/bindings/tabbrowser.xml
Line: 1441

So they are not the same, even after using console.js/xul/css and
consoleBindings.xml from the 1.4.1 branch!

Here are new, more clear I hope, steps to reproduce:

1)add the attached overlay as \content\navigator\no-strict-warnings.xul to comm.jar
  - I used infozip WIZ (any other zip proggy should work?)

2)add the following line to:
mozilla\chrome\overlayinfo\navigator\content\overlays.rdf
  <RDF:Seq about="chrome://navigator/content/navigator.xul">
+    <RDF:li>chrome://navigator/content/no-strict-warnings.xul</RDF:li>

3)start mozilla

4)open JS Console

Current result : the JS strict warning is missing
Expected result: how obvious, don't 'hide' JS strict warnings

Comment 16

[HJ]

Boris, you still can't reproduce this bug?

Comment 17

[Boris Zbarsky [:bzbarsky]]

This sounds like a core JS/DOM bug, not a console one... as in, I bet the
warning is simply being suppressed way before the console ever hears about it.

HJ, any chance of a patch to a cvs tree that I could apply and test with to
reproduce this overlay thing?  I don't have any builds whose chrome I'm willing
to mess with, really (and no time to make sure I do said messing right).

Comment 18

[HJ]

"This sounds like a core JS/DOM bug, not a console one..."

Looks like you're right. "dump("\nmessages.length: "+messages.length" on this line:
http://lxr.mozilla.org/seamonkey/source/xpfe/components/console/resources/content/consoleBindings.xml#109
dumps the expected/right number. What component should this bug go to?

Oh, I don't have any CVS tree available right now, for the next two weeks. Not
at home. I hope Neil will make one for you, I e-mailed him already.

Comment 19

[HJ]

Attachment: diff -u navigatorOverlay.xul navigatorOverlay-new.xul

All I could do for now. Hope this helps.

Comment 20

[[e-mail]]

This is really odd - I have the diggler overlay installed, and it tries to refer
to this._elementIDs when a browser window opens, and that warning does get
logged. But I tried putting HJ's warning in viewSource.xul,
viewSourceOverlay.xul and viewsource.js and none of them reported the strict
warning (although the function did get defined, I verified that from the JS
console). Anyway this bug looks like it should be under a different component.

Comment 21

[Phil Schwartau]

Don't have time to test this as thoroughly as HJ, but my instinct
is that this is an embedding issue, rather than anything that has
changed in the JS Engine's production of strict warnings.

cc'ing Brendan for his opinion -

Comment 22

[Brendan Eich [:brendan]]

Someone needs to debug this, but I bet it's not JS engine.  Try DOM level 0. 
Jst, any thoughts?

/be

Comment 23

[Brendan Eich [:brendan]]

Might be a XUL content code bug, but bouncing to DOM level 0 as promised.

/be

Comment 24

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 25

[Andrew McCreight [:mccr8]]

XUL overlays were removed in bug 1426763.