226403 - Wrong data type in getAsInt8 nsIVariant interface

Status: REOPENED

(Core :: XPCOM, defect, P3)

Description

[Wang Xianzhu]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624
Build Identifier: 

In interface nsIVariant:
    PRUint8 getAsInt8();
PRUint8 should be PRInt8.

Also in interface nsIWritableVariant.getAsInt8.


Reproducible: Always

Steps to Reproduce:

Comment 1

[Wang Xianzhu]

I noticed the workaround of this bug in
js/src/xpconnect/tests/components/xpctest_variant.cpp.  I wonder whether PRUint8
in nsIVariant.setAsInt8 is with intent.

Comment 2

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 3

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.

Comment 4

[Andrew McCreight [:mccr8]]

Nika noticed this issue again recently.

This is also kind of an issue because ConvertToInt8 is implemented as though it was int8, so I guess there's some undefined behavior here:

NUMERIC_CONVERSION_METHOD_NORMAL(VTYPE_INT8, uint8_t, Int8, (-127 - 1), 127)

Comment 6

[Masatoshi Kimura [:emk]]

Do we even need this? No one use this method.

Comment 7

[Andrew McCreight [:mccr8]]

Yeah, I think there's a decent argument for getting rid of int8, unint8, int16, uint16, char and wchar options from the interface.

Comment 8

[Andrew McCreight [:mccr8]]

I filed bug 1753476 about removing things from nsIVariant.