227122 - Pie chart link missing from certain tabular reports

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect)

Description

[Jouni Heikniemi]

When I go to a report like

http://landfill.bugzilla.org/bugzilla-tip/report.cgi?bug_file_loc_type=allwordssubstr&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bugidtype=include&chfieldto=Now&emailassigned_to1=1&emailassigned_to2=1&emailcc2=1&emailreporter2=1&emailtype1=substring&emailtype2=substring&field0-0-0=noop&keywords_type=allwords&long_desc_type=allwordssubstr&short_desc_type=allwordssubstr&status_whiteboard_type=allwordssubstr&type0-0-0=noop&y_axis_field=product&width=600&height=350&action=wrap&format=table

I can't see a link to a pie chart version. However, if I click on "Bar" or
"Line" link, I do get those charts appropriately AND a link to the pie chart is
available in the bottom of the page.

Comment 1

[Gervase Markham [:gerv]]

This is working as designed, sort of.

The idea is to protect you from selecting a pie chart when it wouldn't be able
to cope with what you've selected. So, as a pie chart only looks at what you
select for horizontal axis, if you select a vertical axis, it doesn't show the link.

However, the system attempts to Do What You Mean when you only select one axis,
perhaps by switching that axis from horizontally to vertically and vice versa.
This is why the link re-appears.

What we actually need is to disable the pie link when we have _both_ a
horizontal and a vertical defined.

Gerv

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This fixes it.

Gerv

Comment 3

[Jouni Heikniemi]

Comment on attachment 136562 [details] [diff] [review]
Patch v.1

r=jouni

Comment 4

[Gervase Markham [:gerv]]

Fixed. Thanks for playing with my new code and finding this :-)

Checking in template/en/default/reports/report.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/report.html.tmpl,v
 <--  report.html.tmpl
new revision: 1.9; previous revision: 1.8
done

Gerv