Closed
Bug 227123
Opened 21 years ago
Closed 21 years ago
empty tables can have a size
Categories
(Core :: Layout: Tables, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bernd_mozilla, Assigned: bernd_mozilla)
References
()
Details
Attachments
(2 files)
|
982 bytes,
patch
|
Details | Diff | Splinter Review | |
|
980 bytes,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
at least hixie thinks so,
I will soon attach a patch.
|
||
Comment 2•21 years ago
|
||
Woudn't it be better to do the NS_UNCONSTRAINEDSIZE check _before_ doing any
numerical comparisons on the value?
Attachment #137743 -
Flags: superreview?(bz-vacation)
Attachment #137743 -
Flags: review?(bz-vacation)
|
|
||
Comment 4•21 years ago
|
||
Comment on attachment 137743 [details] [diff] [review]
patch rev2
r+sr=bzbarsky if you fix the indentation and remove all those extra
parentheses.
Attachment #137743 -
Flags: superreview?(bz-vacation)
Attachment #137743 -
Flags: superreview+
Attachment #137743 -
Flags: review?(bz-vacation)
Attachment #137743 -
Flags: review+
I see the indentation but I wouldn't like to remove the parentheses. Thats the
coding style that is all over used in this file. I like this coding style, as
it frees me from thinking about precendence.
|
|
||
Comment 6•21 years ago
|
||
Precedence is never an issue when just dealing with boolean operators and == and
!=...
Feel free to keep the parens if that's the style of the file, I guess.
fix checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•