227396 - stack walking code broken on Fedora Core 1

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

blizzard says the stack walking code is broken on Fedora Core 1.  The patch I'll
attach includes the fix that worked for blizzard plus some cleanup

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 136744 [details] [diff] [review]
patch

Well, I couldn't reproduce the problem, but this seems like a nice cleanup...

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch for trace-malloc

Well, I see the problem with trace-malloc.  (I probably didn't rebuild the
right thing before when I tried backing out the other patch.  I had the patch
in my tree before I tested on Fedora.)

Note that without the change in the first part of this diff, the stack trace
shows one too many lines (one past __libc_start_main, which ends up being a
garbage symbol for nsAString::do_AssignFromReadable or something like that).

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 229479 has been marked as a duplicate of this bug. ***

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2004-01-03 11:15/16 -0800.