Closed Bug 227396 Opened 20 years ago Closed 20 years ago

stack walking code broken on Fedora Core 1

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

(Whiteboard: [patch])

Attachments

(2 files)

patch
1.67 KB, patch
bryner
: review+
Details | Diff | Splinter Review
patch for trace-malloc
2.11 KB, patch
bryner
: review+
Details | Diff | Splinter Review 
blizzard says the stack walking code is broken on Fedora Core 1.  The patch I'll
attach includes the fix that worked for blizzard plus some cleanup
Attached patch patch — — Splinter Review 

    
  
Summary: stack walking code broken on Fedore Core 1 → stack walking code broken on Fedora Core 1
Whiteboard: [patch]

    
    

    
  
Comment on attachment 136744 [details] [diff] [review]
patch

Well, I couldn't reproduce the problem, but this seems like a nice cleanup...

        Attachment #136744 -
        Flags: review?(bryner)

    
    

    
  


  
Well, I see the problem with trace-malloc.  (I probably didn't rebuild the
right thing before when I tried backing out the other patch.  I had the patch
in my tree before I tested on Fedora.)

Note that without the change in the first part of this diff, the stack trace
shows one too many lines (one past __libc_start_main, which ends up being a
garbage symbol for nsAString::do_AssignFromReadable or something like that).

    
  

        Attachment #137811 -
        Flags: review?(brendan)

    
    

    
  
*** Bug 229479 has been marked as a duplicate of this bug. ***

        Attachment #136744 -
        Flags: review?(bryner) → review+

        Attachment #137811 -
        Flags: review?(brendan) → review+

    
    

    
  
Fix checked in to trunk, 2004-01-03 11:15/16 -0800.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.