227771 - Migration and product/component create code no longer writes series to database

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect, P1)

Description

[Gervase Markham [:gerv]]

I have a strong suspicion that the checkin for bug 226682 broke migration,
because collectstats.pl doesn't make the now-required explicit call to write the
Series objects it creates to the database.

Gerv

Comment 1

[Gervase Markham [:gerv]]

...or even "checksetup.pl". :-)

Gerv

Comment 2

[Gervase Markham [:gerv]]

In fact, it's not just the migration code, it's several other places too.

Gerv

Comment 3

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Patch to convert other Series creators to new interface.

Gerv

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 137022 [details] [diff] [review]
Patch v.1

Kiko: could you review this? It's a follow-on from the last one. I've created
both components and products, and the Series that get created are fine.

Gerv

Comment 5

[Christian Reis]

Comment on attachment 137022 [details] [diff] [review]
Patch v.1

Looks correct, and the changes are just API-conforming to what was altered in
Series.pm

Note that I can't remember if you changed any of the internal semantics of the
parameter parsing when you did the reorganization; be sure to check if
everything is still working as expected.

Comment 6

[Gervase Markham [:gerv]]

I checked; I didn't change the semantics of Series creation via parameters.

Gerv

Comment 7

[Gervase Markham [:gerv]]

Fixed.

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.255; previous revision: 1.254
done
Checking in editcomponents.cgi;
/cvsroot/mozilla/webtools/bugzilla/editcomponents.cgi,v  <--  editcomponents.cgi
new revision: 1.37; previous revision: 1.36
done
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.44; previous revision: 1.43
done

Gerv

Comment 8

[Christian Reis]

Sorry I didn't pick this up on my review for bug 226682 -- I forgot to use grep
on the other callsites :-(