227815 - need to list both native font names and English names in font.name-list.* for CJK fonts

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Isaac Hwak Han]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031208
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031208

Current default values for font.name-list.*.ko have no effect in Korean font
resolution (at least in Windows XP). My suggestion is changing

From:

pref("font.name-list.serif.ko", "Batang, Gulim"); 
pref("font.name-list.sans-serif.ko", "Gulim"); 
pref("font.name-list.monospace.ko", "GulimChe"); 

To:

pref("font.name-list.serif.ko", "바탕, 굴림"); // Batang, Gulim
pref("font.name-list.sans-serif.ko", "굴림"); // Gulim
pref("font.name-list.monospace.ko", "굴림체"); // Gulimche

Reproducible: Always

Steps to Reproduce:
1. Open http://www.google.co.kr
2. Set font preference for Korean to "Arial" or whatever you like for Western font.

Actual Results:  
Korean glyphs are rendered with a random font installed on system.


Expected Results:  
They should be rendered with the safe fallback font.


There is no issue about other CJK fonts. Only Korean fonts matter.

Comment 1

[Isaac Hwak Han]

Sorry. http://www.google.co.kr is not good testcase. (I happened to have "Always
Use Document Fonts" to true and the page overrides font-family:)

Try http://kldp.org/ instead.

Comment 2

[Jungshik Shin]

Well, this was done on purpose. 

 65 pref("font.name.serif.ko", "바탕"); // "Batang" 
 66 pref("font.name.sans-serif.ko", "굴림"); // "Gulim" 
 67 pref("font.name.monospace.ko", "굴림체"); // "GulimChe" 
 68 pref("font.name-list.serif.ko", "Batang, Gulim"); 
 69 pref("font.name-list.sans-serif.ko", "Gulim"); 
 70 pref("font.name-list.monospace.ko", "GulimChe"); 

font.name.serif.ko is searched for before falling back to fonts listed in
font.name-list.serif.ko. On Korean Windows 9x/ME (and Win2k/XP with the default
system locale set to Korean), font names are returned in Korean so that what we
hae in font.name-list.*.ko doesn't matter. On the other hand, on non-Korean Win
9x/ME (and Win2k/XP with the default system locale set to non-Korean), English
font names are returned by Win32 APIs and wouldn't match Korean font names so
that Mozilla falls back to matching fonts listed in font.name-list.*.ko. 


> There is no issue about other CJK fonts. Only Korean fonts matter.

  That's because you tested it on Korean Win9x/ME or Win 2k/XP with Korean
locale. Switch your locale to Japanese and see what happens. 

>Set font preference for Korean to "Arial" or whatever you like for Western font.

Now, this is an interesting twist. I guess your intention is to render Latin
letters with Arial and Korean characters with one of fallback fonts listed in
font.name-list.*.ko. In that case, we have to list both Korean and English names
in font.name-list.*.ko.  We've got to do the equivalent for ja and zh-* list. 

Comment 3

[Isaac Hwak Han]

Ah, your comment revealed the true intention of font.name-list.*.ko.

>>Set font preference for Korean to "Arial" or whatever you like for Western font.
>
>Now, this is an interesting twist. I guess your intention is to render Latin
>letters with Arial and Korean characters with one of fallback fonts listed in
>font.name-list.*.ko.

Yes, I like this tweak because of at least 3 reasons.

1. It simply looks better. (better design, ClearType support on LCD, etc.)
2. Workaround for bug 192379 (close underline issue)
3. Workaround for bug 91190 (Unicode font pref issue; marked as Future)

Comment 4

[Jungshik Shin]

Attachment: patch

I added font names in native scripts to *name-list.(ko,zh*,ja). While I was at
it, I also added 'Gungseo' to font.name.cursive.ko

Comment 5

[Jungshik Shin]

changing the summary line.

As for bug 192379, we should fix it, but it's really mysterious...
As for bug 91190, I should have fixed  it a long time ago, but ....
I may do it with a brute force on a slow-going saturday afternoon...

Comment 6

[rbs]

Comment on attachment 137052 [details] [diff] [review]
patch

r+sr=rbs

Comment 7

[Jungshik Shin]

Comment on attachment 137052 [details] [diff] [review]
patch

thanks for r/sr.
Asking for a1.6b

This is not very urgent so I planned to ask for a1.6 after 1.6b release
(nonetheless nice to have because it offers a sorta work-around for a couple of
bugs.), but I realized that beyond 1.6b, I can't make a change that affects
L10N before 1.6final. This may or may not require L10N change. 

Risk : very low
Affected platform : Win32
Affected users: CJK users on CJK windows who configure fonts for CJK langGroups
to Western fonts to render Latin letters and numbers in a Western font with
usually a lot better glyphs for Latin letters than CJK fonts.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 137052 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to Mozilla 1.6.

Comment 9

[Jungshik Shin]

Thanks all. Got landed a moment ago.