227962 - [FIX] accesskey on checkbox element don't work if it has the focus

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Gabriel Barros]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7

Mozilla ignores 

Reproducible: Always

Steps to Reproduce:
1. Set accesskey "a" for a checkbox element
2. viewing the rendered page, Press alt+a, or simply click on the label of the
element.
3. The element will be checked and get the focus
4. Press Alt+a again to uncheck it, while it still has the focus

Actual Results:  
Nothing happens

Expected Results:  
toggle the checked state of the element

Comment 1

[Gabriel Barros]

Attachment: test case for the accesskey ignoring the focused element bug

Comment 2

[Bill Mason]

->Keyboard Navigation

Comment 3

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

The problem is that |EventTargetIn| returns PR_TRUE because the event manager
GetEventTargetContent is the same as the label's "for-content" when the
"for-content" has been focused.

This is not the most beautiful solution, but it fixes the problem...

Comment 4

[Mats Palmgren (inactive)]

Another way of solving it would be to check for this case in |EventTargetIn|
and return PR_FALSE instead, but I'm not entirely sure what |EventTargetIn| is
supposed to do in the first place...

Comment 5

[Boris Zbarsky [:bzbarsky]]

Hmm.. So the ESM is dispatching an event to the _label_, right?  Why is
EventTargetIn returning true then?

Comment 6

[Boris Zbarsky [:bzbarsky]]

The fix for bug 234455 fixed this, looks like.