228149 - messages with attachments imported from Eudora don't show properly

Status: RESOLVED WORKSFORME

(MailNews Core :: Import, defect)

Description

[Guillermo Rodriguez Garcia]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007 Firebird/0.7
Build Identifier: Mozilla Thunderbird 0.4 (20031205)

I'm trying to import my mailboxes from Eudora 5.1. Messages without attachments
are imported fine, but for every message with an attachment, if I preview the
message in the preview pane in Thunderbird or open the message by double
clicking on it, the message text does not show up -- instead, it appears as an
additional attachment (typically called "Part 1.1").

However if I select "Edit as new" then in the compose window the text _does_
show up properly.

Here's a copy of a message which exhibits this problem; this is taken from the
original Eudora mbx file. Actual addresses have been removed.

=== Cut ===
From ???@??? Fri Oct 24 09:16:23 2003
Return-Path: <[e-mail]>
Delivered-To: [e-mail]
Received: from es-01 (110.Red-217-127-14.pooles.rima-tde.net [217.127.14.110])
	by firewall1.sms.nl (Postfix) with SMTP
	id 2B57D2F752F; Fri, 24 Oct 2003 09:04:45 +0200 (CEST)
X-Sender: [e-mail]
X-Mailer: Windows Eudora Version 1.4.3
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=====================_1067011594==_"
To: [e-mail]
From: [e-mail]
Subject: new rev CS8900
Cc: [e-mail]
X-Attachments: D:\MYFILES\ATT\PCN_330B.DOC;D:\MYFILES\ATT\PCN_330B.RTF;
Message-Id: <[e-mail]>
Date: Fri, 24 Oct 2003 09:04:45 +0200 (CEST)
X-UIDL: 2ae908f9e359c11c4ac4b73566143e61

Doesn't seem to have any impact, except a revision register which is
not checked by the driver.

Attachment Converted: "d:\eudora\attach\PCN_330B.DOC"

Attachment Converted: "d:\eudora\attach\PCN_330B.RTF"

--
http://www.snijder.com/
=== Cut ===

Here's a copy of the imported message, taken from the mailbox file created by
Thunderbird:

=== Cut ===
From - Mon Jan 1 00:00:00 1965
Return-Path: <[e-mail]>
Delivered-To: [e-mail]
Received: from es-01 (110.Red-217-127-14.pooles.rima-tde.net [217.127.14.110])
	by firewall1.sms.nl (Postfix) with SMTP
	id 2B57D2F752F; Fri, 24 Oct 2003 09:04:45 +0200 (CEST)
X-Sender: [e-mail]
X-Mailer: Windows Eudora Version 1.4.3
Mime-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------080306020305090400030706"
To: [e-mail]
From: [e-mail]
Subject: new rev CS8900
Cc: [e-mail]
X-Attachments: D:\MYFILES\ATT\PCN_330B.DOC;D:\MYFILES\ATT\PCN_330B.RTF;
Message-Id: <[e-mail]>
Date: Fri, 24 Oct 2003 09:04:45 +0200 (CEST)
X-UIDL: 2ae908f9e359c11c4ac4b73566143e61

This is a multi-part message in MIME format.
--------------080306020305090400030706
Content-Type: 
Content-Transfer-Encoding: 8bit

Doesn't seem to have any impact, except a revision register which is
not checked by the driver.

Attachment Converted: "d:\eudora\attach\PCN_330B.DOC"

Attachment Converted: "d:\eudora\attach\PCN_330B.RTF"

--
http://www.snijder.com/


--------------080306020305090400030706
Content-Type: application/msword;
 name="Attached File"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
 filename="Attached File"

[...rest removed...]
=== Cut ===


Reproducible: Always

Steps to Reproduce:
1. Create a .mbx file containing the message shown in the Detail section (the
one taken from the Eudora .mbx file).

2. Import that mailbox from Thunderbird.

3. Try to open the message.

Actual Results:  
Thunderbird displays (both in preview pane and in the actual message window) a
blank message with no text and three, instead of two attachments. The
'additional' attachment is called "Part 1.1" and seems to contain the message
text. Selecting "Edit as new" shows the message properly (text shows up as such
and there are two attachments only)

Expected Results:  
Thunderbird should display the message text as such, instead of adding it as an
additional attachment.

Not sure whether this really belongs to "Import" or whether it should be
"Attachments", "MIME", or "Mail window front end".

Comment 1

[Guillermo Rodriguez Garcia]

Could also be the case that this is a Thunderbird-specific issue ...

Comment 2

[guanxi]

Eudora 3.x imports to Moz 1.3 with problems, but not this problem, so perhaps it
is a Thunderbird specific issue.

I note the snippet from the Thunderbird mailbox lacks the X-Mozilla headers.  I
don't know Thunderbird, but they should be there in Mozilla suite.  When we
converted from Eudora 3.x to Moz 1.3, we had to manually add them.  Compressing
mailboxes also added them.

Finally, I note this header:
>  X-Mailer: Windows Eudora Version 1.4.3
1.4.3?

Comment 3

[Guillermo Rodriguez Garcia]

This is still present with Thunderbird 0.6, exactly the same symptoms.

Comment 4

[Yann Rouillard]

I have the same problem, it happens when the mail content-type is multipart/mixed; 
In that case event the first part, whose content-type is text/plain, is
displayed as an attached file.

Comment 5

[guanxi]

confirming

Comment 6

[Yann Rouillard]

I had a look at the imported mail content and it seems that after the import
process the content-type of the first part simply disappeared. 
The mail whose content is displayed as an attached part has the following line:

This is a multi-part message in MIME format.
--------------070000010807080207080008
Content-Type: 
Content-Transfer-Encoding: 8bit

And a normal mail has the following line:

--=-LE1YmzMfbVzHGoihCRz3
Content-Type: text/plain
Content-Transfer-Encoding: 8bit


I had a look at the mail in the eudora mailbox file and it seems that Eudora
remove the content-type header from the mail (and also the bounadry markers) !!!
So the import function didn't know what kind of content it was.
Here is a part of the content of the mail in the eudora mailbox file:

Content-Type: multipart/mixed; boundary="=-Gw072fPiZ46p2iKfeSd5"
Message-Id: <1083937304.658.15.camel@moldavite>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Fri, 07 May 2004 15:41:45 +0200

qsdqsd
qsd
qsd
qsd
qs
d
qs
d
qsd





Pièce jointe convertie :
"e:\docume~1\admini~1\applic~1\qualcomm\eudora\attach\toto.txt"

Comment 7

[Yann Rouillard]

Attachment: A proposed patch to solve this bug

This patch solves the problem by forcing the content-type to text/plain when no
content-type is provided, which is the case for all multipart message in
eudora.
As a result the mail content is correctly displayed.

I am looking for a better solution which would also solve the bug 3157 (HTML
not properly displayed). I think we should create a function which would remove
eudora markers (x-html and x-folded) and determine the body type.

Comment 8

[Ryan Holliday]

For messages with boundaries shouldn't the content-type be of the form
"Content-Type: multipart/alternative; boundary=xxxxxxx" instead of just
"text/plain"?

Comment 9

[Guillermo Rodriguez Garcia]

(In reply to comment #8)
> For messages with boundaries shouldn't the content-type be of the form
> "Content-Type: multipart/alternative; boundary=xxxxxxx" instead of just
> "text/plain"?

The content type that is being forced to text/plain is the one corresponding to
the text part only, not the one describing the multipart message.

Comment 10

[Yann Rouillard]

Yes exactly.

I made a new patch which also removes Eudora Tags and solves Bug 3157. 
See this bug to have a look at the patch.

Comment 11

[Boris 'pi' Piwinger]

I also just run into this bug. The reason clearly is that Eudora does not save
as mbox (as often claimed), but into some weird special format. Since this
looses data for the user setting dataloss and critical.

You should request review and superreview for your patch, else nobody will have
look.

pi

Comment 12

[Scott MacGregor]

Comment on attachment 147943 [details] [diff] [review]
A proposed patch to solve this bug

I think the string management can be a little tighter here. 

Lose nsString defaultBodyType

and just do:

pMimeType = ToNewCString(NS_LITERAL_CSTRING("text/plain"));

Post a new patch and ask for sr again. Thanks!

Comment 13

[Scott MacGregor]

Comment on attachment 147943 [details] [diff] [review]
A proposed patch to solve this bug

actually this is probably even better:

pMimeType = strdup("text/plain");

Comment 14

[Frank Wein [:mcsmurf]]

Can someone check if this bug is fixed now (with a nightly build), since Bug
3157 has been fixed?

Comment 15

[Scott MacGregor]

Yeah I didn't make a separate fix for this because I thought it would be fixed
by 3157. Confirmation of that would be ideal.

Comment 16

[Guillermo Rodriguez Garcia]

Still present as of Thunderbird 0.7.3

Comment 17

[Guillermo Rodriguez Garcia]

*** Bug 242492 has been marked as a duplicate of this bug. ***

Comment 18

[Asa Dotzler [:asa]]

not going to block the alpha on this. we'd probably take a fix if one materializes.

Comment 19

[Matt Dudziak]

(In reply to comment #18)
> not going to block the alpha on this. we'd probably take a fix if one
> materializes.
> 

I think this is fixed as part of the importer improvements in the Penelope project.

Comment 20

[Wayne Mery (:wsmwk)]

Nikolay are you also able to test import from Eudora?

Comment 21

[Wayne Mery (:wsmwk)]

(In reply to Matt Dudziak from comment #19)
> (In reply to comment #18)
> > not going to block the alpha on this. we'd probably take a fix if one
> > materializes.
> > 
> 
> I think this is fixed as part of the importer improvements in the Penelope
> project.

gonna take Matt's judgement