228218 - Cannot save media (image,...) from page info (validateFileName is not defined)

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Gilles Durys]

Since bug 223549, validateFileName has been moved out of contentAreaUtils.js to
utilityOverlay.js.
This cause the save media feature to fail.

Comment 1

[Gilles Durys]

Attachment: one-line patch to include utilityOverlay.js

Comment 2

[Gilles Durys]

Comment on attachment 137271 [details] [diff] [review]
one-line patch to include utilityOverlay.js

A simple patch like that could be in 1.6

Comment 3

[Daniel Brooks [:db48x]]

nice of them to do that for us :P

I'll just need to double check to see if page info still needs contentAreaUtils.js

Comment 4

[Asa Dotzler [:asa]]

not being able to save from the page info dialog isn't going to block 1.6 but
we'd certainly consider a reviewed patch for approval to land in 1.6. Time is
short so if this is gonna make it we'll need reviews to happen quickly.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 137271 [details] [diff] [review]
one-line patch to include utilityOverlay.js

please request approval *after* you've secured the necessary reviews

Comment 6

[Andreas Kunz]

Please have a look at what bug 225740 is trying to do, maybe this bug is fixed
there (I didn't look at it).

Comment 7

[Andreas Kunz]

Gilles: Asa set review flags, but without requesting review from a particular
person you will never get one.

Comment 8

[Gilles Durys]

*** Bug 231470 has been marked as a duplicate of this bug. ***

Comment 9

[Simon Paquet [:sipaq]]

Comment on attachment 137271 [details] [diff] [review]
one-line patch to include utilityOverlay.js

Asking David Brooks since he does most of the work in Page Info now.
Also requesting 'rs= '

Comment 10

[Andreas Kunz]

Re comment #3: contentAreaUtils.js is still needed, e.g. because of function
saveURL.

Comment 11

[Daniel Brooks [:db48x]]

Comment on attachment 137271 [details] [diff] [review]
one-line patch to include utilityOverlay.js

looks good, r=db48x

See also bug 225740, when that goes in this will have to include utility.js
instead

Comment 12

[Daniel Brooks [:db48x]]

checked in.

Comment 13

[Thomas Brown]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040209

Verified WFM - thanks!