Closed Bug 228218 Opened 16 years ago Closed 16 years ago

Cannot save media (image,...) from page info (validateFileName is not defined)

Categories

(SeaMonkey :: Page Info, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mozbug, Assigned: mozbug)

References

Details

Attachments

(1 file)

Since bug 223549, validateFileName has been moved out of contentAreaUtils.js to
utilityOverlay.js.
This cause the save media feature to fail.
Status: NEW → ASSIGNED
Assignee: db48x → mozbug
Status: ASSIGNED → NEW
Comment on attachment 137271 [details] [diff] [review]
one-line patch to include utilityOverlay.js

A simple patch like that could be in 1.6
Attachment #137271 - Flags: superreview?
Attachment #137271 - Flags: review?
Attachment #137271 - Flags: approval1.6?
Flags: blocking1.6?
nice of them to do that for us :P

I'll just need to double check to see if page info still needs contentAreaUtils.js
not being able to save from the page info dialog isn't going to block 1.6 but
we'd certainly consider a reviewed patch for approval to land in 1.6. Time is
short so if this is gonna make it we'll need reviews to happen quickly.
Flags: blocking1.6? → blocking1.6-
Comment on attachment 137271 [details] [diff] [review]
one-line patch to include utilityOverlay.js

please request approval *after* you've secured the necessary reviews
Attachment #137271 - Flags: approval1.6?
Summary: Cannot save media → Cannot save media (image,...) from page info
Please have a look at what bug 225740 is trying to do, maybe this bug is fixed
there (I didn't look at it).
Summary: Cannot save media (image,...) from page info → Cannot save media (image,...) from page info (validateFileName is not defined)
Gilles: Asa set review flags, but without requesting review from a particular
person you will never get one.
*** Bug 231470 has been marked as a duplicate of this bug. ***
Comment on attachment 137271 [details] [diff] [review]
one-line patch to include utilityOverlay.js

Asking David Brooks since he does most of the work in Page Info now.
Also requesting 'rs= '
Attachment #137271 - Flags: superreview?(bryner)
Attachment #137271 - Flags: superreview?
Attachment #137271 - Flags: review?(db48x)
Attachment #137271 - Flags: review?
Re comment #3: contentAreaUtils.js is still needed, e.g. because of function
saveURL.
Comment on attachment 137271 [details] [diff] [review]
one-line patch to include utilityOverlay.js

looks good, r=db48x

See also bug 225740, when that goes in this will have to include utility.js
instead
Attachment #137271 - Flags: review?(db48x) → review+
Attachment #137271 - Flags: superreview?(bryner) → superreview+
checked in.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040209

Verified WFM - thanks!
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.