228320 - When any sidebar is active, a 5-pixel spacer appears on the left of all popups

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jeremy Jongsma]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031130 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031130 Firebird/0.7+

When a sidebar (such as bookmarks or history) is active, any popup windows
display a 5-pixel gray spacer on the left side of the pop-up page where a
sidebar would normally be.

Reproducible: Always

Steps to Reproduce:
1. Activate bookmarks
2. Restart Firebird
3. Go to a site that opens a popup window

Actual Results:  
A spacer is displayed on the left side of the popup window.  This is better than
the old behavior of displaying the whole sidebar, but it shouldn't be displaying
anything.

Expected Results:  
Nothing should be displayed (hit CTL-B in the popup for the spacer to disappear
- this is how it should always look)

Comment 1

[PikeUK]

Confirming (well saying it anyway) on:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040119
Firebird/0.8.0+

This can be fixed by giving the splitter the chromeclass-extrachrome class.

Comment 2

[PikeUK]

Attachment: Patch adding class attribute as described in comment #1

No more orphaned splitter in popups with this patch applied.

Comment 3

[logan]

Sure would be nice to get this in for 0.9.

These sidebar bits in popups have been a problem since phoenix 0.5, maybe
earlier. This should be the last of it.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 139431 [details] [diff] [review]
Patch adding class attribute as described in comment  #1

r=[e-mail]

Comment 5

[Mike Connor [:mconnor]]

not a blocker, will check this in soon.

Comment 6

[Mike Connor [:mconnor]]

checked in on 1.7 branch and trunk, 2004-04-25 13:08

thanks Pike!