228510 - Warning ``function getContentTypeFromHeaders does not always return a value'' [xs] in file ``chrome://navigator/content/pageInfo.js'', line 951, character 0.

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[timeless]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031208

Warning ``function getContentTypeFromHeaders does not always return a value''
[xs] in file ``chrome://navigator/content/pageInfo.js'', line 951, character 0.

Comment 1

[timeless]

Attachment: (Av1) |return ""| [Checked in: Comment 4]

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 137436 [details] [diff] [review]
(Av1) |return ""|
[Checked in: Comment 4]

sr=bzbarsky, sure

Comment 3

[[e-mail]]

Comment on attachment 137436 [details] [diff] [review]
(Av1) |return ""|
[Checked in: Comment 4]

...although I would have preferred null, because that's nearer to what it used
to "return".

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 137436 [details] [diff] [review]
(Av1) |return ""|
[Checked in: Comment 4]


Check in: { 12/20/2003 20:04	timeless%mozdev.org	1.60 }

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) |return null|, and localization

As suggested by comment 3, and a little more.
(In fact, replacing Av1 :-<)

Comment 6

[timeless]

personally, if you're going to do that i'd change the code to be:

function getContentTypeFromHeaders(cacheEntryDescriptor)
{
  if (!cacheEntryDescriptor)
    return null;

  var headers = cacheEntryDescriptor.getMetaDataElement("response-head");
  var match = /^Content-Type:\s*(.*?)\s*(?:\;|$)/mi.exec(headers);
  return match[1];
}

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1b) |return null|, and var removals [== Bv1 :-(]

Bv1, with comment 6 suggestion.

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Bv2) |return null|, and var removals

(My mistake: Bv1b was still Bv1 :-()

Bv1, with comment 6 suggestion.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 137926 [details] [diff] [review]
(Bv2) |return null|, and var removals

sr=bzbarsky if you add another set of parens around the whole //.exec()
construction... (I think that will be more readable.)

Comment 10

[Serge Gautherie (:sgautherie)]

Attachment: (Bv2b) |return null|, and var removals [Checked in: Comment 12]

Bv2, with comment 9 suggestion(s).

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 137949 [details] [diff] [review]
(Bv2b) |return null|, and var removals
[Checked in: Comment 12]


(Bv2) 'bz-vacation: superreview+'. (from comment 9)

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 137949 [details] [diff] [review]
(Bv2b) |return null|, and var removals
[Checked in: Comment 12]


Check in: { 12/25/2003 16:01	neil%parkwaycc.co.uk	1.61 }

Comment 13

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6) Gecko/20040113] (W98SE)

Argh ... This patch(s) is not in v1.6: too bad ;-<