228533 - Compiler warning in security/nss/lib/softoken/pkcs11u.c

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[tenthumbs]

Building a Linux trunk mozilla, gcc says:

pkcs11u.c:751: warning: implicit declaration of function `PR_ntohl'

Obviously a missing include file. This isn't a really big problem but it should
be fixed.

Comment 1

[Wan-Teh Chang]

This has been fixed by Nelson Bolyard in rev. 1.53 of
security/nss/lib/softoken/pkcs11u.c.  This fix will
eventually be propagated to NSS_CLIENT_TAG.

% cvs diff -u -r1.52 -r1.53 pkcs11u.c
Index: pkcs11u.c
===================================================================
RCS file: /cvsroot/mozilla/security/nss/lib/softoken/pkcs11u.c,v
retrieving revision 1.52
retrieving revision 1.53
diff -u -r1.52 -r1.53
--- pkcs11u.c   15 Nov 2003 00:10:01 -0000      1.52
+++ pkcs11u.c   6 Dec 2003 06:41:51 -0000       1.53
@@ -45,6 +45,7 @@
 #include "secasn1.h"
 #include "blapi.h"
 #include "secerr.h"
+#include "prnetdb.h" /* for PR_ntohl */

 /*
  * ******************** Attribute Utilities *******************************
@@ -1323,7 +1324,6 @@
     PK11Attribute *attribute;
     unsigned int size;
     unsigned char *ptr;
-    int i,j;

     attribute = pk11_FindAttribute(object, type);
     if (!attribute) {
@@ -1922,7 +1922,6 @@
 pk11_GetULongAttribute(PK11Object *object, CK_ATTRIBUTE_TYPE type,
                                                         CK_ULONG *longData)
 {
-    int len;
     PK11Attribute *attribute;

     attribute = pk11_FindAttribute(object, type);