228566 - Cleanup & optimizaton: privacy-button incorrectly uses a 'taskbutton' inside a 'statusbarpanel-iconic'

Status: VERIFIED DUPLICATE of bug 235190

(SeaMonkey :: UI Design, defect)

Description

[Alfred Kayser]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031214
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031214

cookieTasksOverlay.xul uses the following code to add a cookie button in the
statusbar:
113     <statusbarpanel class="statusbarpanel-iconic" id="privacy-button"
114                     hidden="true" insertbefore="security-button"
115                     oncommand="viewP3PDialog()"
tooltiptext="&cookieIcon.label;">
116       <toolbarbutton class="taskbutton" id="mini-cookie"
117                     
image="chrome://communicator/skin/cookie/taskbar-cookie.gif"/>
118     </statusbarpanel>

While navigator.xul uses the following:
336    <statusbarpanel class="statusbarpanel-iconic" id="security-button"
337                     onclick="BrowserPageInfo(null, 'securityTab')"/>

The main difference is the 'taskbutton' inside the statusbarpanel-iconic.
Furthermore, also the chrome path to the cookie icon is hardcoded in the XUL itself.

This could easily be replaced with:
     <statusbarpanel class="statusbarpanel-iconic" id="privacy-button"
                     hidden="true" insertbefore="security-button"
                     onclick="viewP3PDialog()"/>
With the icon definition in global.css (or navigator.css?):
#privacy-button {
   list-style-image: url("chrome://communicator/skin/cookie/taskbar-cookie.gif");
}

While the 'themers' don't like a theme change (but this is a small one,
and at least this themer doesn't object), everybody hates
hardcoded references to images in the chrome.
 


Reproducible: Always

Steps to Reproduce:

Comment 1

[Alfred Kayser]

Attachment: Quick and simple patch

Comment 2

[Alfred Kayser]

Note, this also removes the hard dependency from /content/ to /skin/:
chrome://communicator/skin/cookie/taskbar-cookie.gif is directly referenced.

Comment 3

[Alfred Kayser]

Bug 235190 may have a different summary, but the patch is 
effectively the same. So the issue of this bug is therefor
closed with the fixing of 235190

*** This bug has been marked as a duplicate of 235190 ***

Comment 4

[Darin Fisher]

Comment on attachment 137477 [details] [diff] [review]
Quick and simple patch

removing review request since bug has been closed.

Comment 5

[benc]

V/dupe