229589 - nsBaseHashtable::Init documentation is outdated

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P4)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

92    * Initialize the object.
 93    * @param initSize the initial number of buckets in the hashtable,
 94    *        default 16
 95    * @param threadSafe whether to provide read/write
 96    * locking on all class methods
 97    * @return    PR_TRUE if the object was initialized properly.
 98    */
 99   PRBool Init(PRUint32 initSize = PL_DHASH_MIN_SIZE)

obviously, there is no threadSafe parameter.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

also, same file, comment above nsBaseHashtable decl:
 72  * destruction. Thread-safety is optional, via a flag in Init()

Comment 2

[Benjamin Smedberg]

Attachment: Remove obsolete threadsafety javadocs.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 197457 [details] [diff] [review]
Remove obsolete threadsafety javadocs.

lost the period on the last comment change.

Comment 4

[Benjamin Smedberg]

Comment on attachment 197457 [details] [diff] [review]
Remove obsolete threadsafety javadocs.

This is doc-only, so it should be absolutely safe and would be nice to get on
the branch for the 1.8 SDK.

Comment 5

[Benjamin Smedberg]

fixed on trunk

Comment 6

[Mike Schroepfer]

Comment on attachment 197457 [details] [diff] [review]
Remove obsolete threadsafety javadocs.

Approved per 9/26 bug triage meeting.

Comment 7

[Benjamin Smedberg]

Fixed on 1.8 branch.