nsBaseHashtable::Init documentation is outdated

RESOLVED FIXED

Status

()

Core
XPCOM
P4
normal
RESOLVED FIXED
14 years ago
12 years ago

People

(Reporter: Biesinger, Assigned: bsmedberg)

Tracking

({fixed1.8})

Trunk
x86
Linux
fixed1.8
Points:
---
Bug Flags:
blocking1.8b5 +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

92    * Initialize the object.
 93    * @param initSize the initial number of buckets in the hashtable,
 94    *        default 16
 95    * @param threadSafe whether to provide read/write
 96    * locking on all class methods
 97    * @return    PR_TRUE if the object was initialized properly.
 98    */
 99   PRBool Init(PRUint32 initSize = PL_DHASH_MIN_SIZE)

obviously, there is no threadSafe parameter.
also, same file, comment above nsBaseHashtable decl:
 72  * destruction. Thread-safety is optional, via a flag in Init()
(Assignee)

Updated

12 years ago
Keywords: helpwanted
Priority: -- → P4
Whiteboard: [good first bug]
(Assignee)

Comment 2

12 years ago
Created attachment 197457 [details] [diff] [review]
Remove obsolete threadsafety javadocs.
Attachment #197457 - Flags: review?(dougt)

Comment 3

12 years ago
Comment on attachment 197457 [details] [diff] [review]
Remove obsolete threadsafety javadocs.

lost the period on the last comment change.
Attachment #197457 - Flags: review?(dougt) → review+
(Assignee)

Comment 4

12 years ago
Comment on attachment 197457 [details] [diff] [review]
Remove obsolete threadsafety javadocs.

This is doc-only, so it should be absolutely safe and would be nice to get on
the branch for the 1.8 SDK.
Attachment #197457 - Flags: approval1.8b5?
(Assignee)

Comment 5

12 years ago
fixed on trunk
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 6

12 years ago
Comment on attachment 197457 [details] [diff] [review]
Remove obsolete threadsafety javadocs.

Approved per 9/26 bug triage meeting.
Attachment #197457 - Flags: approval1.8b5? → approval1.8b5+

Updated

12 years ago
Flags: blocking1.8b5+
(Assignee)

Comment 7

12 years ago
Fixed on 1.8 branch.
Keywords: helpwanted → fixed1.8
Whiteboard: [good first bug]
You need to log in before you can comment on or make changes to this bug.