Closed
Bug 229903
Opened 21 years ago
Closed 21 years ago
bogus QueryInterface methods in bookmarks.js
Categories
(SeaMonkey :: Bookmarks & History, defect)
SeaMonkey
Bookmarks & History
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: p_ch)
Details
Attachments
(1 file)
|
4.45 KB,
patch
|
p_ch
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
As neil pointed out in bug 196756 comment 26, a bunch of transaction objects in
bookmarks.js have a bogus QueryInterface method. This should be fixed. The
objects seem to implement nsISupports, nsIClassInfo (partially -- but do they
need to?), nsISecurityCheckedComponent (likewise), and nsITransaction.
Furthermore, these objects seem to have a bunch of identical methods, which
suggests that those methods could be on the common base class |BookmarkTransaction|.
|
||
Comment 1•21 years ago
|
||
Since nobody actually calls QueryInterface it's not necessary to implement it -
XPConnect will automatically create an nsITransaction wrapper for it.
|
|
||
Updated•21 years ago
|
Attachment #138302 -
Flags: review?(p_ch)
|
Assignee | |
Comment 2•21 years ago
|
||
Comment on attachment 138302 [details] [diff] [review]
Proposed patch
There is no more need for those interfaces. I guess that's the case since the
bookmarks transaction manager has been moved to the bookmarks service.
Note that we still should fix bug 168411: Transactions are created in a js
context that can disappear.
Attachment #138302 -
Flags: review?(p_ch) → review+
|
|
||
Updated•21 years ago
|
Attachment #138302 -
Flags: superreview?(dbaron)
|
Reporter | |
Updated•21 years ago
|
Attachment #138302 -
Flags: superreview?(dbaron) → superreview+
|
|
||
Comment 3•21 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•