Closed Bug 229903 Opened 20 years ago Closed 20 years ago
Interface methods in bookmarks .js
As neil pointed out in bug 196756 comment 26, a bunch of transaction objects in bookmarks.js have a bogus QueryInterface method. This should be fixed. The objects seem to implement nsISupports, nsIClassInfo (partially -- but do they need to?), nsISecurityCheckedComponent (likewise), and nsITransaction. Furthermore, these objects seem to have a bunch of identical methods, which suggests that those methods could be on the common base class |BookmarkTransaction|.
Since nobody actually calls QueryInterface it's not necessary to implement it - XPConnect will automatically create an nsITransaction wrapper for it.
Comment on attachment 138302 [details] [diff] [review] Proposed patch There is no more need for those interfaces. I guess that's the case since the bookmarks transaction manager has been moved to the bookmarks service. Note that we still should fix bug 168411: Transactions are created in a js context that can disappear.
Attachment #138302 - Flags: review?(p_ch) → review+
Attachment #138302 - Flags: superreview?(dbaron) → superreview+
Fix checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.