230030 - <xmlparse.c>: Fix 'Control reaches end of non-void function' from 'Blamed Build Warnings; Linux brad Clobber'; and code cleanup.

Status: RESOLVED WONTFIX

(SeaMonkey :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

The ("bogus") warning is:

{ tao
1.	expat/xmlparse/xmlparse.c:2106 (See build log excerpt)
	Control reaches end of non-void function

2104   }
2105   /* not reached */
2106 }
2107 
2108 #endif /* XML_DTD */
}

The code is right, but the compiler does not track the preceding |abort()|.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) warning fix, and code cleanup

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 138378 [details] [diff] [review]
(Av1) warning fix, and code cleanup


I have no compiler: Could you compile/test/review it ? Thanks.

Note: from <http://www.mozilla.org/owners.html>,
'hjtoi#comcast.net', 'peter#propagandism.org' and 'sicking#bigfoot.com' are
obsolete :-(

Comment 3

[Boris Zbarsky [:bzbarsky]]

Note that xmlparse.c is part of a separate library (expat) which is not
developed by Mozilla.org and that we try to minimize the changes we make to
expat (so upgrading to a new version is as painless as possible)...

Comment 4

[Serge Gautherie (:sgautherie)]

Agreed.
Would there be a mean to get it fixed at the source ?
Who should I contact ?

Comment 5

[Ian Graham]

There's information on Expat at http://expat.sourceforge.net/.  I don't know
which version Mozilla uses, but current development is run out of the
Sourceforge site. YOu could review the bug list there, and submit an Expat bug
report -- 

Comment 6

[Johnny Stenback (:jst)]

Peterv might know more about this.

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 138378 [details] [diff] [review]
(Av1) warning fix, and code cleanup

Please re-request reviews if we do want this fixed in the Mozilla expat code.

Comment 8

[Peter Van der Beken [:peterv]]

I'll just WONTFIX this.
Bug 192139 will update our Expat to a later version and we want to keep the
changes between our version and the official version to a minimum to avoid merge
problems when upgrading. If you want to fix this, download the latest Expat and
provide a patch to the Expat people.
You should compile and test your patches *before* asking for review.
The owners page is often incorrect and we'll try to get it corrected, but
looking for the right address is quite simple: just fill in part of the name and
Bugzilla will give you possible matches. Peter would have given you
[e-mail] as one of the matches and Sicking would have given you
[e-mail].