230137 - The function _PR_NativeRunThread is of incorrect type.

Status: RESOLVED DUPLICATE of bug 216021

(NSPR :: NSPR, defect)

Description

[Jim Polubinski Jr.]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1

Recently, while looking at Mozilla in the debugger, I noticed some threads
exited with a non-zero exit code, although they were exiting normally.  The
problem seems to be the function _PR_NativeRunThread; its type should be
unsigned __stdcall _PR_NativeRunThread(void*) in pruthr.c (as required by
_beginthreadex).  

Reproducible: Sometimes

Steps to Reproduce:
1. Attach a debugger to firebird, and see the output.
2. 
3.




See <URL:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclib/html/_crt__beginthread.2c_._beginthreadex.asp>
for the definitions of the beginthread family of functions.

Comment 1

[Mike Connor [:mconnor]]

-> NSPR, apologize if its a dupe

Comment 2

[Jim Polubinski Jr.]

[2004-01-05, Jim Polubinski Jr.]
I apologize if this breaks process, but the important part of this bug is to fix
the calling convention; not doing that might lead to a hard to find bug due to
stack corruption (the two calling conventions in question, _cdecl (the default)
and __stdcall (to be changed to) do it differently).

Comment 3

[Wan-Teh Chang]

Thanks for the bug report.  This has been fixed.

*** This bug has been marked as a duplicate of 216021 ***