Closed
Bug 230304
Opened 21 years ago
Closed 19 years ago
Remove obsolete browser.tabs.opentabfor.bookmarks prefs
Categories
(SeaMonkey :: Tabbed Browser, defect)
SeaMonkey
Tabbed Browser
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: alther, Assigned: Gavin)
Details
Attachments
(1 file)
1.12 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 My understanding of the browser.tabs.opentabfor.bookmarks setting is that if I set it to 'true', then clicking on a bookmark should open it in another tab rather than replacing the current one. If this is the case, then this feature does not work. I have tested this with Mozilla 1.5 on Windows XP and Mozilla 1.6b on Linux. Some other tab preferences settings I have in case there is a conflict somewhere (on both systems): browser.tabs.autoHide = 'true' browser.tabs.forceHide = 'false' broswer.tabs.loadGroup = 1 broswer.tabs.loadInBackground = 'true' broswer.tabs.loadOnNewTab = 0 broswer.tabs.opentabfor.urlbar = 'true' broswer.tabs.opentabfor.windowopen = 'false' Reproducible: Always Steps to Reproduce: 1. Set the broswer.tabs.opentabfor.bookmarks setting in user.js file user_pref("browser.tabs.opentabfor.bookmarks", true); 2. restart browser. 3. Go to a web page if the home page isn't loaded. 4. Click on a bookmark. Notice the page is replaced rather than opened in a new tab. Actual Results: The bookmark page replaced the current tab. Expected Results: Should have opened the bookmark in a new tab (either in the foreground or background depending on the browser.tabs.loadInBackground setting).
Comment 1•21 years ago
|
||
I don't think that setting is supposed to do anything...
Comment 2•21 years ago
|
||
I don't think that setting ever did anything...
Reporter | ||
Comment 3•21 years ago
|
||
Even if the setting never worked, that means it's broken, right? Someone added that setting for a reason, even if it has never been completed. I like the idea of clicking on my bookmarks and having them open in a tab. Right now, if I want to click a bookmark, I have to open a new tab first. Certainly not the end of the world, but bookmarks now no longer work like links (I can click them and put them in a new tab) or URLs on the address bar (CTRL-Enter to put in a tab). Bookmarks are the only 'links' that can never be put directly into a tab. Adding this capability to bookmarks would make the UI uniform rather than having exceptions for different 'types' of links.
Comment 4•21 years ago
|
||
the pref browser.tabs.opentabfor.windowopen isn't used neither. they should be removed.
Comment 5•21 years ago
|
||
Rick: we'd better use a modifier (ctrl) here as we do in FB.
Reporter | ||
Comment 6•21 years ago
|
||
That's fine too. I don't mind Ctrl-Click on a bookmark to open it up in a new tab...but it should probably respect the browser.tabs.opentabfor.middleclick setting. i.e. if it's false, Ctrl-Click does nothing special.
Comment 7•21 years ago
|
||
> i.e. if it's false, Ctrl-Click does nothing special.
well, if false, ctrl+click should open a new window like everywhere else in
mozilla...
Summary misses the "s" for browser.tabs.opentabfor.bookmarks. See Bug 102157 for the disuse of this pref. Dupe? (In reply to comment #4) > the pref browser.tabs.opentabfor.windowopen isn't used neither. See Bug 105547, which removed the UI and use of this pref.
Comment 9•20 years ago
|
||
Confirming. Unless we want to keep this as a placeholder for future functionality, a pref that does nothing is a bug. It should either be removed or implemented. Prog.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•20 years ago
|
Summary: browser.tabs.opentabfor.bookmark setting does not work → browser.tabs.opentabfor.bookmarks setting does not work
Updated•20 years ago
|
Summary: browser.tabs.opentabfor.bookmarks setting does not work → Remove obsolete browser.tabs.opentabfor.bookmarks setting
Assignee | ||
Updated•20 years ago
|
Assignee: tabbed-browser → gavin.sharp
OS: Windows XP → All
Hardware: PC → All
Summary: Remove obsolete browser.tabs.opentabfor.bookmarks setting → Remove obsolete browser.tabs.opentabfor.bookmarks prefs
Assignee | ||
Comment 10•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Severity: normal → trivial
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Attachment #168003 -
Flags: review?(p_ch)
Comment 11•20 years ago
|
||
Dan, FireFox doesn't use this windowopen pref for window diversion, right?
Severity: trivial → normal
Comment 12•20 years ago
|
||
These prefs are still unused, even in the new code. They were added for bug 105214, part of a strawman UI, never hooked up as far as I know. They've already been removed from most other files where they appeared.
Updated•20 years ago
|
Attachment #168003 -
Flags: superreview+
Attachment #168003 -
Flags: review?(p_ch)
Attachment #168003 -
Flags: review+
Assignee | ||
Updated•20 years ago
|
Whiteboard: checkin-needed
Assignee | ||
Updated•19 years ago
|
Whiteboard: checkin-needed → [checkin needed]
Comment 13•19 years ago
|
||
I checked this in as I was checking in the fix to bug 231984.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Comment 14•19 years ago
|
||
(In reply to comment #12) > These prefs are still unused, even in the new code. They were added for bug > 105214, part of a strawman UI, never hooked up as far as I know. They've already > been removed from most other files where they appeared. I wonder, will they appear in the new "Options" window in Firefox then?
Assignee | ||
Updated•19 years ago
|
Status: RESOLVED → VERIFIED
Updated•16 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•