230429 - Progress broken in progress window when saving / opening attachments

Status: RESOLVED FIXED

(MailNews Core :: Networking, defect)

Description

[Scott MacGregor]

Open or save a large attachment that brings up the external helper app's
progress dialog.

Note that the progress bar is defunct and never increases.

This is because of the following code used to update the progress dialog:

http://lxr.mozilla.org/mozilla/source/uriloader/exthandler/nsExternalHelperAppService.cpp#1635

We never set the ContentLength field for any of the mail protocols.

I don't understand the code in question anymore since we are correctly
broadcasting progress totals through the web progress interface via the
docloader just fine. I don't understand why that does not work for the progress
dialog.

In any case, small patch coming up for imap. Need another one for nsMsgProtocol.

Comment 1

[Scott MacGregor]

Attachment: fix for imap

I think this is relatively safe because we use a new mock channel for each new
imap request. We aren't effecting anything on the persistent imap channel.

Comment 2

[Scott MacGregor]

Comment on attachment 138643 [details] [diff] [review]
fix for imap

Looks like this already works today for mailbox urls. I see that
nsMailboxProtocol::GetContentLength has a valid definition.

Comment 3

[David :Bienvenu]

Comment on attachment 138643 [details] [diff] [review]
fix for imap

I'm happy to try running with this - sorry for the delay - I just got the
bugmail this morning.

Comment 4

[Scott MacGregor]

fixed.

Comment 5

[Scott MacGregor]

checked into the M4 branch.