230440 - Remove NS_NewStringInputStream and 'fix' callers

Status: RESOLVED DUPLICATE of bug 1240436

(Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Streams are streams of bytes, not of characters. This makes it seem like a bad
idea to support creating one from an nsACString: it is unclear what the encoding
will be and just generally makes no sense.

the current implementation is also somewhat useless :) (truncates the characters
to the lower 8 bits)

Comment 1

[Boris Zbarsky [:bzbarsky]]

You mean nsAString, not nsACString, right?  Creating a byte stream from
nsACString has no issues...

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

er, yeah. nsAString.

Comment 3

[Jungshik Shin]

I guess removing it should be done together with fixing callers. With that
change, this bug blocks 230275. In its place, we might want to have
NS_NewUTF8StringInputStream.
 

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

One particularily bad caller of this is nsRDFXMLParser::ParseString, which takes
a nsString argument, and then sets the charset to UTF8.  i.e., it expects you to
pass in UTF8 in a nsString as it stands.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Yes, we know.  That's why this bug blocks bug 230275.

Comment 6

[(Away)]

Fixed by:

https://hg.mozilla.org/mozilla-central/rev/f851d6d56143
Bug 1240436 - Part3: Remove NS_NewStringInputStream to prevent misuse. r=froydnj