Last Comment Bug 230704 - [FIX]CSS parser allows comments in the middle of some function tokens
: [FIX]CSS parser allows comments in the middle of some function tokens
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: x86 Linux
: P1 normal (vote)
: mozilla1.7alpha
Assigned To: Boris Zbarsky [:bz]
: Hixie (not reading bugmail)
Mentors:
http://www.richinstyle.com/test/keyco...
Depends on:
Blocks: 153699
  Show dependency treegraph
 
Reported: 2004-01-12 09:40 PST by Boris Zbarsky [:bz]
Modified: 2004-01-12 17:01 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (2.05 KB, patch)
2004-01-12 09:44 PST, Boris Zbarsky [:bz]
dbaron: review+
dbaron: superreview+
Details | Diff | Review

Description Boris Zbarsky [:bz] 2004-01-12 09:40:39 PST
See last test at http://www.richinstyle.com/test/keyconcepts/comments2.html

Basically, we treat the selector ":lang/* */(fr)" as identical to ":lang(fr)". 
That's wrong.
Comment 1 Boris Zbarsky [:bz] 2004-01-12 09:44:55 PST
Created attachment 138880 [details] [diff] [review]
Patch
Comment 2 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2004-01-12 15:07:27 PST
Comment on attachment 138880 [details] [diff] [review]
Patch

r+sr=dbaron if you put a rather verbose comment above the definition of
|isTree| explaining how that interacts with what you just added to allow the
tree pseudo-elements to be optionally functional.
Comment 3 Boris Zbarsky [:bz] 2004-01-12 17:01:29 PST
Added:

  // If a tree pseudo-element is using the function syntax, it will
  // get isTree set here and will pass the check below that only
  // allows functions if they are in our list of things allowed to be
  // functions.  If it is _not_ using the function syntax, isTree will
  // be false, and it will still pass that check.  So the tree
  // pseudo-elements are allowed to be either functions or not, as
  // desired.


and checked in.

Note You need to log in before you can comment on or make changes to this bug.