The default bug view has changed. See this FAQ.

[FIX]CSS parser allows comments in the middle of some function tokens

RESOLVED FIXED in mozilla1.7alpha

Status

()

Core
CSS Parsing and Computation
P1
normal
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.7alpha
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

See last test at http://www.richinstyle.com/test/keyconcepts/comments2.html

Basically, we treat the selector ":lang/* */(fr)" as identical to ":lang(fr)". 
That's wrong.
Priority: -- → P1
Summary: CSS parser allows comments in the middle of some function tokens → [FIX]CSS parser allows comments in the middle of some function tokens
Target Milestone: --- → mozilla1.7alpha
Created attachment 138880 [details] [diff] [review]
Patch
Attachment #138880 - Flags: superreview?(dbaron)
Attachment #138880 - Flags: review?(dbaron)
Comment on attachment 138880 [details] [diff] [review]
Patch

r+sr=dbaron if you put a rather verbose comment above the definition of
|isTree| explaining how that interacts with what you just added to allow the
tree pseudo-elements to be optionally functional.
Attachment #138880 - Flags: superreview?(dbaron)
Attachment #138880 - Flags: superreview+
Attachment #138880 - Flags: review?(dbaron)
Attachment #138880 - Flags: review+
Added:

  // If a tree pseudo-element is using the function syntax, it will
  // get isTree set here and will pass the check below that only
  // allows functions if they are in our list of things allowed to be
  // functions.  If it is _not_ using the function syntax, isTree will
  // be false, and it will still pass that check.  So the tree
  // pseudo-elements are allowed to be either functions or not, as
  // desired.


and checked in.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.