230717 - Microsoft Keyboard Search and Web/Home buttons should map to appropriate places

Status: RESOLVED WORKSFORME

(Core :: DOM: UI Events & Focus Handling, enhancement)

Description

[Gids Goldberg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7

My Microsoft Internet Keyboard
(http://www.microsoft.com/hardware/mouseandkeyboard/productdetails.aspx?pid=021)
has some buttons at the top to aid web navigation, the buttons for 'Stop' 'Back'
'Forward' and 'Home' work fine in Firebird, but the buttons 'Search' and
'Favorites' don't work.
I suggest that the search button be mapped to the Search toolbar, and the
Favorites button be mapped to the bookmarks sidebar. 
Here are the results I get from Keyboard Test Page at
http://bugzilla.mozilla.org/attachment.cgi?id=55849&action=view

Search button keyCode 170
Favorites button KeyCode 171 


Reproducible: Always

Steps to Reproduce:

Comment 1

[Gids Goldberg]

I have found using the latest build:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20040102
Firebird/0.7+
The favourites link now works, however, the search link still doesn't work, and
to correct my previous message the Web/Home button doesn't work correctly, it
launches the default browser with a new window. The correct behaviour is to
return the active window to its homepage (it seems like windows is initiating
the action and firebird has no part in it, with the Web/Home key.

Web/Home button KeyCode 172 

Comment 2

[Sebastian Brocks]

I can confirm this with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6)
Gecko/20040120 Firebird/0.7+ and with Mozilla/5.0 (Windows; U; Windows NT 5.1;
en-US; rv:1.7a) Gecko/20040120, this should be changed to Browser instead of
Firebird.
The 'Search' and 'Home' buttons both just launch an empty default browser window.
Relevant other bugs are http://bugzilla.mozilla.org/show_bug.cgi?id=13168 and
possibly http://bugzilla.mozilla.org/show_bug.cgi?id=66519

Comment 3

[Gids Goldberg]

I think it would be helpful if we could identify the code that was added which
maps the favourites key correctly, I know it was added between Firebird 0.7 and
the latest builds, presumably we could adapt this code to the other functions. 
When the key is pressed it appears that keypresses Ctrl+B are subsequently sent
to the browser.

Comment 4

[Simon Paquet [:sipaq]]

*** Bug 223401 has been marked as a duplicate of this bug. ***

Comment 5

[Asa Dotzler [:asa]]

*** Bug 222255 has been marked as a duplicate of this bug. ***

Comment 6

[Aaron Leventhal]

Does the same functions on the IBM Thinkpad keyboard work the same way?
See bug 225846.

Comment 7

[Erlendur S Thorsteinsson]

I have a Logitech keyboard and the "WWW" button does not work with Firefox.  The Keyboard Test Page says:

     1) keydown charCode=0 keyCode=172 character=
     2) keypress charCode=0 keyCode=172 character=
     3) keyup charCode=0 keyCode=172 character=

when I press the key.  The system default browser should open, but only works if IE is default, not if FX is default.

Google Desktop's "Quick Search Box" (see bug #334163) also doesn't work with Firefox, maybe related issues?

Comment 8

[Adam Guthrie]

I'm pretty sure this was fixed by bug 360731 (which was basically an overhaul of how these keyboard shortcuts worked). Can someone please verify?

Comment 9

[Mattias Jiderhamn]

(In reply to comment #8)
> I'm pretty sure this was fixed by bug 360731 (which was basically an overhaul
> of how these keyboard shortcuts worked). Can someone please verify?

No this has NOT been fixed. Pressing the Web/Home key on my MS Internet Keyboard still opens up a new window of the OS default browser in 2.0.0.2.

Comment 10

[Adam Guthrie]

I forgot to mention that you need to use a trunk [0] build to test since the patch hasn't landed on branch. I would advise creating a new profile [1] to test this on trunk.

[0] http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/
[1] http://kb.mozillazine.org/Profile_Manager

Comment 11

[Mattias Jiderhamn]

(In reply to comment #8)
> I'm pretty sure this was fixed by bug 360731 (which was basically an overhaul
> of how these keyboard shortcuts worked). Can someone please verify?
> 

Problem seems to be resolved in latest nightly build.
Will this be backported to 2.0???

Comment 13

[David Bolter [:davidb] (NeedInfo me for attention)]

Mass un-assigning bugs assigned to Aaron.

Comment 14

[Mattias Jiderhamn]

This was fixed in FF 3.0

Comment 15

[Andrew Rose]

I can confirm it's fixed in 3.5b99.

Comment 16

[Asa Dotzler [:asa]]

Resolving per above comments.