230778 - Remove @mozilla.org/preferences;1 from chrome

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[[e-mail]]

Apart from the previous bugs I have filed, the preference panels are the only
chrome using the deprecated preferences.

Comment 1

[[e-mail]]

Attachment: The easy bits

In some cases I have used parent.hPrefWindow.pref which will then become the
last chrome variable using deprecated preferences.

Comment 2

[[e-mail]]

Attachment: The appropriate bits

Whoops, I included some parts of other patches in the previous diff :-[

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 138940 [details] [diff] [review]
The appropriate bits

Don't you also need to do something with nsPrefWindow.js, and the things in the
patch which call CopyCharPref?

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 138940 [details] [diff] [review]
The appropriate bits

Via e-mail, Neil says: "Yes, but that's a big job - I wanted to clean up the
other files first."

Fair enough.  r=caillon then.

Comment 5

[jag (Peter Annema)]

Comment on attachment 138940 [details] [diff] [review]
The appropriate bits

Marking r=caillon, adding sr=jag.

Comment 6

[[e-mail]]

Attachment: The rest

Sorry for taking so long with this, I couldn't figure out why the fonts panel
behaved differently on my patched Linux build and my unpatched MingW build
until I twigged that some of the font size defaults are missing on Linux.

Comment 7

[[e-mail]]

Requesting blocking based on dependency.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

If we plus the dependency, we'll plus the dependency, but no need to mark two
bugs as blocking for a single issue.

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 138940 [details] [diff] [review]
The appropriate bits

This patch was just backed out to fix bug 231769.  When the tree reopens, it
will need to be relanded.

Comment 10

[[e-mail]]

Attachment: Whole patch, updated to trunk

This is smaller than the sum of the previous two!

Comment 11

[jag (Peter Annema)]

Comment on attachment 141683 [details] [diff] [review]
Whole patch, updated to trunk

sr=jag

Comment 12

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 141683 [details] [diff] [review]
Whole patch, updated to trunk

>@@ -273,7 +274,9 @@ nsPrefWindow.prototype =
>               }
>               try 
>                 {
>-                  this.pref.savePrefFile(null);
>+                  Components.classes["@mozilla.org/preferences-service;1"]
>+                            .getService(Components.interfaces.nsIPrefService)
>+                            .savePrefFile(null);

It might make sense to cache this; but maybe not.  I can't really tell from the
context, but I figured I'd put it in your mind to decide.

Comment 13

[[e-mail]]

Fix checked in. Fingers crossed ;-)