230998 - [FIX]crash if I'm opening file upload after I submit form.

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[volod]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007

Mozilla crashes if I submit form and before the page is updated I press
"Browse..." button to upload file. After the page updated (file upload window is
still open), file is selected and open button is press mozilla crashes.

Reproducible: Always

Steps to Reproduce:
1. need a form with file upload input (<input type="file">)
2. submit form and  press "Browse..." button (before the page is updated)
3. after the page is refreshed press "Open" button

Actual Results:  
browser crashes

Comment 1

[Gilles Durys]

*** Bug 230997 has been marked as a duplicate of this bug. ***

Comment 2

[Frank Wein [:mcsmurf]]

wfm current cvs trunk build
Reporter: Maybe you can try with the current 1.6 release?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> wfm current cvs trunk build

On Linux?  'cause I can sure reproduce on Linux with a current trunk build...

Comment 4

[Boris Zbarsky [:bzbarsky]]

The crash happens because mTextFrame is 0xdddddddd

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

This makes us not crash.

The right behavior, imo, is to take the filepicker down when the page
transition happens, but I see no way to do this via the filepicker
interfaces...  We should probably have a general "take this down if the page
transitions" flag on windows (eg find dialogs, filepickers, etc).

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 139295 [details] [diff] [review]
Patch

David, would you review?

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 139295 [details] [diff] [review]
Patch

Sure, but move the "Set property" comment back to where it was (below the
inserted code).

Comment 8

[Boris Zbarsky [:bzbarsky]]

Checked in.  volod, thanks for the bug report!

Comment 9

[Frank Wein [:mcsmurf]]

ok that was on Windows where i tried it, should have added this; anyway glad
this is fixed now :)

Comment 10

[Boris Zbarsky [:bzbarsky]]

*** Bug 235359 has been marked as a duplicate of this bug. ***