Closed Bug 231018 Opened 20 years ago Closed 20 years ago

Streamline NSS configuration for AIX


(NSS :: Build, defect)

Not set


(Not tracked)



(Reporter: pkwarren, Assigned: wtc)



(1 file, 3 obsolete files)

Currently, the NSS build configuration for AIX is spread across several files,
with several duplicated settings. I would like to merge the common settings into, using the AIX`uname -v`.`uname-r`.mk files for specific settings needed
for particular AIX releases.
Attached patch Patch v1 (obsolete) — Splinter Review
- Moves common settings into
- Removes obsolete EXPORT_RULES variable from (not used anywhere in
- Removes -DAIX4_2 from We don't even support AIX 4.2 anymore, but
this define is not used anywhere in the security code so there is no need to
have this.
- Removes -DAIX4_3 from since it is unused.
Attachment #139142 - Flags: review?(wchang0222)

I encourage you to go a step further and move everything
into, eliminating the need for the
AIX`uname -v`.`uname-r`.mk files.  Then, add AIX to the
TARGET_OSES list at line 61 of security/coreconf/
Attachment #139142 - Attachment is obsolete: true
Attachment #139142 - Flags: review?(wchang0222)
Attached patch Patch v2 (obsolete) — Splinter Review
- Removes all AIX version specific files.
- Removes support for AIX 3 and AIX 4 (< 4.3). These required special
configuration, but they are no longer supported platforms and no one is
building on them.
- Cleans up whitespace.
Attachment #139425 - Flags: review?(wchang0222)
Attachment #139425 - Attachment is obsolete: true
Attachment #139425 - Flags: review?(wchang0222)
Attached patch Patch v3 (obsolete) — Splinter Review
Same patch as before but adds -bnortllib to DSO_LDOPTS.
Attachment #139996 - Flags: review?(wchang0222)
Comment on attachment 139996 [details] [diff] [review]
Patch v3

r=wtc.	Philip, I will make the following two changes
before checking this in.  Please let me know if you
think that's OK.

In security/coreconf/

>+OS_LIBS 	= -blibpath:/usr/lib:/lib -lc -lm

I want to use "+=" instead of "=".


I want to change "$(OS_LIBS)" to
"-blibpath:/usr/lib:/lib -lc -lm".

The purpose of these two changes is to match exactly
the original,, and files.
Attachment #139996 - Flags: review?(wchang0222) → review+
Attached patch Patch v4Splinter Review
Philip, this is your patch v3 with my proposed changes.
Comment on attachment 140023 [details] [diff] [review]
Patch v4

This looks fine. I would've preferred to only have the blibpath and math/c
libraries in one location in the file, but this is still an improvement over
the existing setup.
Attachment #140023 - Flags: review+
Patch v4 checked into the NSS tip (NSS 3.10), NSS_3_9_BRANCH (NSS 3.9.1),
and NSS_CLIENT_TAG (Mozilla 1.7a).
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.9.1
Attachment #139996 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.