Closed Bug 231034 Opened 21 years ago Closed 21 years ago

Tab doesn't scroll though address list

Categories

(MailNews Core :: Composition, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.7alpha

People

(Reporter: neil, Assigned: mscott)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Steps to reproduce problem:
1. Compose a message with more than 4 recipients
2. Try to tab through the list of recipients

Expected results: address list scrolls to allow you to tab through

Actual results: tabbing jumps to subject after the 4th recipient

Additional information: back tabbing still scrolls correctly
Attached patch the fix (obsolete) — Splinter Review
9 is really the value of KeyEvent.DOM_VK_TAB so my KeyEvent.DOM_VK_TAB case
statement caused us to never hit the original case.

The fix is to just fold the call to awTabFromRecipient up into the switch for 
KeyEvent.DOM_VK_TAB / KeyEvent.DOM_VK_RETURN.
Attachment #140183 - Flags: review?(neil.parkwaycc.co.uk)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.7alpha
Comment on attachment 140183 [details] [diff] [review]
the fix

r=me if you delete the { on line 855 instead of adding } after the break;
Attachment #140183 - Flags: review?(neil.parkwaycc.co.uk) → review+
Attachment #140183 - Attachment is obsolete: true
Comment on attachment 140245 [details] [diff] [review]
updated patch with neil's comments

moving forward the r, requesting sr.
Attachment #140245 - Flags: superreview?(bienvenu)
Attachment #140245 - Flags: review+
Attachment #140245 - Flags: superreview?(bienvenu) → superreview+
fixed
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment on attachment 140245 [details] [diff] [review]
updated patch with neil's comments

Sigh, the only difference between these patches was the indentation of the
else...
maybe the diff is wrong I removed the braces around the case statement like you
asked.
*sigh* I didn't save the changes in my editor before I generated the diff.

I'll check it in again :)
Yeah, I've done that and wondered why my bugs don't get fixed ;-)
Fix works great, Neil; verifying.

How about putting the same logic into a fix for bug 216212?
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: