231034 - Tab doesn't scroll though address list

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[[e-mail]]

Steps to reproduce problem:
1. Compose a message with more than 4 recipients
2. Try to tab through the list of recipients

Expected results: address list scrolls to allow you to tab through

Actual results: tabbing jumps to subject after the 4th recipient

Additional information: back tabbing still scrolls correctly

Comment 1

[Mike Cowperthwaite]

xref bug 216212.

Comment 2

[Scott MacGregor]

Attachment: the fix

9 is really the value of KeyEvent.DOM_VK_TAB so my KeyEvent.DOM_VK_TAB case
statement caused us to never hit the original case.

The fix is to just fold the call to awTabFromRecipient up into the switch for 
KeyEvent.DOM_VK_TAB / KeyEvent.DOM_VK_RETURN.

Comment 3

[[e-mail]]

Comment on attachment 140183 [details] [diff] [review]
the fix

r=me if you delete the { on line 855 instead of adding } after the break;

Comment 4

[Scott MacGregor]

Attachment: updated patch with neil's comments

Comment 5

[Scott MacGregor]

Comment on attachment 140245 [details] [diff] [review]
updated patch with neil's comments

moving forward the r, requesting sr.

Comment 6

[Scott MacGregor]

fixed

Comment 7

[[e-mail]]

Comment on attachment 140245 [details] [diff] [review]
updated patch with neil's comments

Sigh, the only difference between these patches was the indentation of the
else...

Comment 8

[Scott MacGregor]

maybe the diff is wrong I removed the braces around the case statement like you
asked.

Comment 9

[Scott MacGregor]

*sigh* I didn't save the changes in my editor before I generated the diff.

I'll check it in again :)

Comment 10

[[e-mail]]

Yeah, I've done that and wondered why my bugs don't get fixed ;-)

Comment 11

[Mike Cowperthwaite]

Fix works great, Neil; verifying.

How about putting the same logic into a fix for bug 216212?