231039 - Bookmarks divider (splitter) does not remember state

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Daniel Andrews]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7a) Gecko/20040115 Camino/0.7+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7a) Gecko/20040115 Camino/0.7+

something i have noticed lately is that the bookmark manager does not remember
it's state between sessions. for example, if i move the bar dividing the
categories (top 10, menu bar, history, etc) farther to the left, then close
window i'm working in, next time i use the bookmarks manager, the view is at
it's default state.

this also applies to the bar at the bottom, with search results


Reproducible: Always

Steps to Reproduce:
1.open bookmarks manager
2.adjust the position or size of a window in the bookmarks manager
3.close the window
4.note the window sizes are at their default again.

Actual Results:  
the window sizes did not save their state

Expected Results:  
the sizes and positions of the colums in the bookmarks manager should be
retained between sessions.

Comment 1

[Mike Pinkerton (not reading bugmail)]

i checked in the other change slider fix already, morphing this to the work that
remains.

Comment 2

[Jasper]

Changing summary as we no longer have a results view. But the root bookmarks
dividers still doesn't save it's coordinates.

Comment 3

[Simon Fraser [no longer active]]

Taking.

Comment 4

[Mike Pinkerton (not reading bugmail)]

*** Bug 294672 has been marked as a duplicate of this bug. ***

Comment 5

[Mike Pinkerton (not reading bugmail)]

i *swear* this worked in 0.8. what's up?

Comment 6

[Simon Fraser [no longer active]]

What's up is that ther's a method, -focus, where the splitter state is restored,
is not called any more after my 'content view provider' changes, because the BM
view controller doesn't actually know when the bm view is added to the window,
and hence sized correctly. Though I guess it could cue off a -viewDidMoveToWindow.

Comment 7

[Samuel Sidler (old account; do not CC)]

Simon, since you know "what's up", is this easily fixable?

Comment 8

[Simon Fraser [no longer active]]

Fixed.