Closed
Bug 231172
Opened 22 years ago
Closed 13 years ago
Remove editor.encode_entity
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: benjamin, Assigned: Cykesiopka)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.73 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Followup to bug 224578, uncomment the editor.encode_entity pref in all.js
|
||
Updated•16 years ago
|
QA Contact: preferences-backend
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #741733 -
Flags: review?(benjamin)
|
Reporter | |
Updated•13 years ago
|
Attachment #741733 -
Flags: review?(benjamin) → review?(ehsan)
|
|
Reporter | |
Updated•13 years ago
|
Assignee: timeless → cykesiopka
Component: Preferences: Backend → Editor
|
||
Comment 3•13 years ago
|
||
Can somebody please explain the background behind this change?
Flags: needinfo?(benjamin)
|
|
||
Comment 4•13 years ago
|
||
I mean, I don't see any code in mozilla-central which uses the editor.encode_entity pref.
|
|
||
Comment 5•13 years ago
|
||
AFAIK this code was removed in bug 445146.
|
|
Reporter | |
Comment 6•13 years ago
|
||
This is a bug filed in 2004. Removing the pref is the right solution?
Flags: needinfo?(benjamin)
|
|
||
Comment 7•13 years ago
|
||
(In reply to comment #6)
> This is a bug filed in 2004. Removing the pref is the right solution?
Yes!
|
|
||
Updated•13 years ago
|
Summary: uncomment the editor.encode_entity → Remove editor.encode_entity
|
|
||
Updated•13 years ago
|
Attachment #741733 -
Flags: review?(ehsan) → review-
|
|
Assignee | |
Comment 8•13 years ago
|
||
Attachment #741733 -
Attachment is obsolete: true
Attachment #742612 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 9•13 years ago
|
||
What should be done about the same commented out pref in composer.js in comm-central?
|
|
||
Comment 10•13 years ago
|
||
(In reply to Cykesiopka from comment #9)
> What should be done about the same commented out pref in composer.js in
> comm-central?
To be honest I'm not sure what this pref is supposed to do.
|
|
||
Updated•13 years ago
|
Attachment #742612 -
Flags: review?(ehsan) → review+
|
|
||
Comment 11•13 years ago
|
||
|
||
Comment 12•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
||
Comment 13•13 years ago
|
||
(In reply to Cykesiopka from comment #9)
> What should be done about the same commented out pref in composer.js in
> comm-central?
That is interesting question, this pref is used in two places
http://mxr.mozilla.org/comm-central/search?string=editor.encode_entity
but I can't say what consequences brings either uncommenting or removal of it...
You need to log in
before you can comment on or make changes to this bug.
Description
•