Closed Bug 231172 Opened 16 years ago Closed 7 years ago

Remove editor.encode_entity

Categories

(Core :: Editor, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: benjamin, Assigned: Cykesiopka)

References

Details

Attachments

(1 file, 1 obsolete file)

Followup to bug 224578, uncomment the editor.encode_entity pref in all.js
That is right, otherwise it is not discoverable in about:config.
QA Contact: preferences-backend
Attached patch Proposed Patch v1 (obsolete) — Splinter Review
Attachment #741733 - Flags: review?(benjamin)
Attachment #741733 - Flags: review?(benjamin) → review?(ehsan)
Assignee: timeless → cykesiopka
Component: Preferences: Backend → Editor
Can somebody please explain the background behind this change?
Flags: needinfo?(benjamin)
I mean, I don't see any code in mozilla-central which uses the editor.encode_entity pref.
AFAIK this code was removed in bug 445146.
This is a bug filed in 2004. Removing the pref is the right solution?
Flags: needinfo?(benjamin)
(In reply to comment #6)
> This is a bug filed in 2004. Removing the pref is the right solution?

Yes!
Summary: uncomment the editor.encode_entity → Remove editor.encode_entity
Attachment #741733 - Flags: review?(ehsan) → review-
Attached patch Removal Patch v1Splinter Review
Attachment #741733 - Attachment is obsolete: true
Attachment #742612 - Flags: review?(ehsan)
What should be done about the same commented out pref in composer.js in comm-central?
(In reply to Cykesiopka from comment #9)
> What should be done about the same commented out pref in composer.js in
> comm-central?

To be honest I'm not sure what this pref is supposed to do.
Attachment #742612 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/d95d80a1580b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
(In reply to Cykesiopka from comment #9)
> What should be done about the same commented out pref in composer.js in
> comm-central?
That is interesting question, this pref is used in two places
http://mxr.mozilla.org/comm-central/search?string=editor.encode_entity
but I can't say what consequences brings either uncommenting or removal of it...
You need to log in before you can comment on or make changes to this bug.