Closed Bug 231266 Opened 16 years ago Closed 16 years ago
leak on starting and exiting Firebird
Starting and exiting firebird, there's a bunch of stuff leaked. I think the root is a cycle through JS involving the observer service and an implementation of nsIObserver in JS. The wrapped JS object in this cycle roots its global object, etc. The information I have on this cycle is: 08741478 object 0x880f808 XPCWrappedNative_NoHelper via nsXPCWrappedJS::mJSObj(Object).observe(Function).__parent__(Call).service(XPCWrappedNative_NoHelper). plus a pair of stacks that I'll attach.
This looks like a problem: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser.js&rev=1.265&mark=201,211-212#198 The closure creates a cycle.
...which would make it basically the same as bug 170022.
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → Firebird0.9
This patch fixes the suite as well.
Attachment #139288 - Attachment is obsolete: true
Attachment #139294 - Flags: review?(bryner)
Attachment #139294 - Flags: review?(bryner) → review+
Attachment #139294 - Flags: superreview?(brendan)
Comment on attachment 139294 [details] [diff] [review] patch Sure, the extra function wrapping the object initializer containing a method was unnecessary, a garbage-entrainment hazard. Was this pattern copied/mutated anywhere else? sr=me. /be
Attachment #139294 - Flags: superreview?(brendan) → superreview+
Fix checked in to trunk, 2004-01-17 14:41 -0800.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
And I changed the second addObserver in navigator.js to removeObserver before I checked in.
any ideas when this bug appeared? was it on the 20030114 trunk?
It's been around since before Firebird forked from Seamonkey.
You need to log in before you can comment on or make changes to this bug.