231358 - Menu shortcuts should be invoked by command-<key>, not control-<key> on mac

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Michael Kurze [:michaelk]]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7a) Gecko/20040116 Firebird/0.8.0+
Build Identifier: http://ftp.mozilla.org/pub/mozilla.org/firebird/nightly/2004-01-18-02-trunk/

When using a menu shortcut (open new tab/window, save page, create bookmark...)
command key does not work as the access-modifier, but control does.
Both should not be true.

Reproducible: Always

Steps to Reproduce:
1. Start Mozilla Firebird
2. Try using Cmd-T to open a new tab (or any other command)

Actual Results:  
Nothing happens

Expected Results:  
Firebird should open a new Tab in response.

Using OSX 10.3.2 and a fresh profile

Comment 1

[Michael Kurze [:michaelk]]

Similar Bugs have been submitted before, but this feature has been working for
some time (Gecko/20040116 Firebird/0.8.0+ *does* work), and is now broken again.

Comment 2

[Mike Connor [:mconnor]]

if I so it broke between 01/16 and 01/18?  does 01/17 work?

Comment 3

[Michael Kurze [:michaelk]]

I looked into it:
The first nightly with the bug: Gecko/20040117 Firebird/0.8.0+

Comment 4

[Jerry Talkington]

No, 01/17 does not work (i.e. it was the first build that introduced the problem.)
Seems that this is the checking that busted it:
http://bonsai.mozilla.org/cvsview2.cgi?subdir=mozilla/modules/libpref/src/init&files=all.js&command=DIRECTORY&branch=HEAD&root=/cvsroot

Comment 5

[Simon Paquet [:sipaq]]

*** Bug 231392 has been marked as a duplicate of this bug. ***

Comment 6

[José Jeria]

Confirming based on comments and dupe.

Comment 7

[Mike Connor [:mconnor]]

please test this on tomorrow's nightly, it loks like fallout from bug 224578,
and those issues have been fixed as of now.

Comment 8

[Hiro]

Although it is the thing built by myself from CVS, command+<key> is working by
bug224578 fix.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; ja-JP; rv:1.7a) Gecko/20040119
Firebird/0.8.0+

Comment 9

[Jerry Talkington]

Yes, it's been fixed as of the 11/19 nightly.

Comment 10

[José Jeria]

Does this fix also fix mozilla suite? Seems like it also has the same problem:
bug 231421

Comment 11

[Michael Kurze [:michaelk]]

Both of the following builds work:
[firebird:]
http://ftp.mozilla.org/pub/mozilla.org/firebird/nightly/2004-01-19-02-trunk/
[seamonkey:]
http://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/2004-01-19-05-trunk/

I resolved the bug as fixed.