231493 - Sent folder does not refresh on sending message

Status: RESOLVED WORKSFORME

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Greg Colyer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113

When you send a message, using "Copy to Sent folder" functionality, the open
view of the Sent folder no longer immediately shows the message. You have to
leave Sent and reopen it to refresh.

Reproducible: Always

Steps to Reproduce:
1. Open Sent folder (using IMAP for me)
2. Send a message


Actual Results:  
Sent folder does not show message until you leave Sent folder and then go back in.

Expected Results:  
Shown message in list immediately.

1.6a behaved correctly, as did (I think) earlier versions. I don't know about 1.6b.

Comment 1

[Mike Cowperthwaite]

I don't see this with POP.  Is the Sent folder remote or local?

Comment 2

[Greg Colyer]

> 1. Open Sent folder (using IMAP for me)

> Is the Sent folder remote or local?

The account is a remote IMAP account, and the Sent folder is a folder within
that account. Is that what you're asking?

Comment 3

[R.K.Aa.]

*** Bug 232876 has been marked as a duplicate of this bug. ***

Comment 4

[Greg Colyer]

This bug also affects drafts. Saving a draft with the Drafts folder open does
not show the new draft immediately; you have to leave and re-enter the folder to
see it. Interestingly, in the case of resaving an existing draft, the old draft
does disappear immediately.

Perhaps change the summary to reflect this?

Comment 5

[enraption]

i just downloaded Mozilla 1.7b (windows), and this no longer happens -- i.e.,
the Sent folder refreshes immediately again now!  can anyone else confirm with 1.7b?

Comment 6

[Greg Colyer]

*** This bug has been confirmed by popular vote. ***

Comment 7

[Boying Lu]

*** Bug 289419 has been marked as a duplicate of this bug. ***

Comment 8

[Boying Lu]

I have verified that the bug is caused by one of the patches checked in between
2003-11-28 and 2003-11-29. Because the 2003-11-28 build is fine but the
2003-11-29 is not.

Comment 9

[Boying Lu]

I found that it's related  to one of your patches at
https://bugzilla.mozilla.org/show_bug.cgi?id=206408.
I think the following codes in your patch may have some problem:

RCS file: /cvsroot/mozilla/mailnews/compose/src/nsMsgCopy.cpp,v
...

+  nsCOMPtr <nsIMsgWindow> msgWindow;
+
+  if (aMsgSendObj)
+  {
+    nsCOMPtr <nsIMsgProgress> progress;
+    aMsgSendObj->GetProgress(getter_AddRefs(progress));
+    if (progress)
+      progress->GetMsgWindow(getter_AddRefs(msgWindow));
+  }
+

In this snippet, msgWindow points to the "composer" window, which will be closed
after sending an e-mail.

  if (!waitForUrl)
  {
-    rv = DoCopy(aFileSpec, dstFolder, aMsgToReplace, isDraft, *nsnull*,
aMsgSendObj);
+    rv = DoCopy(aFileSpec, dstFolder, aMsgToReplace, isDraft, *msgWindow*,
aMsgSendObj);
  }

Mozilla will try to update view in msgWindow ( if I guess correctly).  When I
replace the line marked "+" with the line marked "-", the bug 231493 is gone.
I'm not sure if this is correct.

Comment 10

[Boying Lu]

Attachment: patch

After the "Send" button is clicked, following call sequence will occurr:
nsImapMailFolder::SetUrlState
nsUrlListenerManager::OnStopRunningUrl
nsUrlListenerManager::BroadcastChange
nsImapMailFolder::OnStopRunningUrl
nsImapMailFolder::OnCopyCompleted
nsMsgCopyService::NotifyCompletion
nsMsgCopyService::ClearRequest
CopyListener::OnStopCopy
nsMsgComposeAndSend::NotifyListenerOnStopCopy
nsMsgComposeSendListener::OnStopCopy
nsMsgCompose::CloseWindow
nsChromeTreeOwner::Destroy
nsWebShellWindow::Destroy
nsXULWindow::Destroy
nsDocShell::Destroy
nsDocShell::Stop
nsDocShell::Stop
nsDocLoader::Stop
nsLoadGroup::Cancel
nsImapMockChannel::Cancel

The last call will cancel (remove) the update sent folder request from event
queue and nsXULWindow is the composer window. So I think the copy request
should	not be bounded to composer window.

Comment 11

[David :Bienvenu]

do we get status messages in the progress window with your change?

Comment 12

[Boying Lu]

Yes, status message is shown in the progress window.

Comment 13

[Wayne Mery (:wsmwk)]

David, Boying, is there an issue with the patch preventing checkin?

Comment 14

[Boying Lu]

(In reply to comment #13)
> David, Boying, is there an issue with the patch preventing checkin?
>
I haven't got r/sr yet. :(

Comment 15

[David :Bienvenu]

this works fine for me on a debug trunk build, without your patch, with an imap sent mail folder. So I'd like to be able to understand and reproduce the original problem first.

Comment 16

[Wayne Mery (:wsmwk)]

Greg (OP) wrote "I suspect it's fixed in at least the 1.7 branch and SeaMonkey 1.0 branch. (I use Mozilla 1.7.13 and SeaMonkey 1.1 daily..." but has not tested on trunk.

Comment 17

[David :Bienvenu]

Comment on attachment 183568 [details] [diff] [review]
patch

I'm obsoleting this - this works for me on the trunk.

Comment 18

[David :Bienvenu]

marking WFM - please re-open if you have a test case that fails on the trunk