231512 - add an option to disable automatic bookmark checking

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, enhancement)

Description

[S Woodside]

There could be a privacy concern with automatic bookmark checking for people who
take their laptops to work and have employers who monitor their internet usage.

Comment 1

[Mike Pinkerton (not reading bugmail)]

i think we're going to disable it for 0.8, but yeah, we should have one.

Comment 2

[Stuart Morgan]

Attachment: Creates a pref to control automatic bookmark updating

This causes automatic bookmark checking (and the "Broken Bookmarks" folder) to
be dependent on a new camino-only boolean pref, camino.bookmarks.autoupdate.

In order to make it work, I had to re-write some of the smart folder
referencing to be more flexible (rather than using #define'd indexes).	While I
was there, I also fixed some warnings from missing declarations and #imports,
and renamed the bookmark constants to be more correct about what they were for.


Once this lands, we should leave the bug open but morph it to a request for a
GUI for the pref (and corresponding changes to make changing the pref work
without a re-launch).

Comment 3

[Stuart Morgan]

Moving to 0.8, per comment 1

Comment 4

[Mike Pinkerton (not reading bugmail)]

landed on trunk and branch.

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 146213 [details] [diff] [review]
Creates a pref to control automatic bookmark updating

r=pink