231821 - splash is listed in command line help, but it crashes mozilla

Status: RESOLVED WORKSFORME

(Firefox :: General, defect, P2)

Description

[Aaron Peterson]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040120 Firebird/0.8.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040120 Firebird/0.8.0+

Mozilla Firebird crashes when passed -splash or --splash
not when passed -cow

Please enable it or get rid of it... it is very confusing... this is not a
dupliacte of other ones ... because this is marking a crash and or documentation
error.



bash-2.05b$ cd MozillaFirebird
bash-2.05b$ ./MozillaFirebird --splash
/home/aaron/work/firebird/MozillaFirebird/run-mozilla.sh: line 451:  2245
Segmentation fault      (core dumped) "$prog" ${1+"$@"}
bash-2.05b$ ./MozillaFirebird --help
Usage: ./MozillaFirebird-bin [ options ... ] [URL]
       where options include:

X11 options
        --display=DISPLAY               X display to use
        --sync          Make X calls synchronous
        --no-xshm               Don't use X shared memory extension
        --xim-preedit=STYLE
        --xim-status=STYLE
        --g-fatal-warnings              Make all warnings fatal

Mozilla options
        -height <value>         Set height of startup window to <value>.
        -h or -help             Print this message.
        -installer              Start with 4.x migration window.
        -width <value>          Set width of startup window to <value>.
        -v or -version          Print ./MozillaFirebird-bin version.
        -CreateProfile <profile>                Create <profile>.
        -P <profile>            Start with <profile>.
        -ProfileWizard          Start with profile wizard.
        -ProfileManager         Start with profile manager.
        -SelectProfile          Start with profile selection dialog.
        -UILocale <locale>              Start with <locale> resources as UI Locale.
        -contentLocale <locale>         Start with <locale> resources as content
Locale.
        -remote <command>       Execute <command> in an already running
                                Mozilla process.  For more info, see:

                http://www.mozilla.org/unix/remote.html

        -splash         Enable splash screen.
        -jsconsole              Start with Javascript Console
        -edit <url>             Start with editor.
        -chrome <url>           Load the specified chrome.
        -inspector <url>                Start with the DOM Inspector.
bash-2.05b$ ./MozillaFirebird -splash
/home/aaron/work/firebird/MozillaFirebird/run-mozilla.sh: line 451:  2549
Segmentation fault      (core dumped) "$prog" ${1+"$@"}
bash-2.05b$ ./MozillaFirebird -cow
bash-2.05b$



Reproducible: Always

Steps to Reproduce:
1.  ./MozillaFirebird --splash
2.  hehe... splash and crash rhyme!
3. and the ./MozillaFirebird --help to see it listed there.

Actual Results:  
hehe... it... hehe It's core splashed!


Expected Results:  
shown a splash screen or
not shown splash in help

and !!!
not crash when passed unhandeled options.


I think I remember this happening on windows too.

critical because it crashes...
I don't see how it could loose data...   but it is very bad none the less

Comment 1

[Mike Connor [:mconnor]]

Not going to enable it.  You know that already if you read your bugmail.

However, it shouldn't crash.

Comment 2

[Erik J. Anderson]

Attachment: Backtrace of splash & crash

Backtrace of the -splash & crash.

Simply use firefox -splash

Wheres the bug mail that mentioned Mike Connor? That way I wouldn't be adding
to the confusion :)

Comment 3

[David Hallowell]

Attachment: Hack to disable -splash and remove from list of command line options

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 141491 [details] [diff] [review]
Hack to disable -splash and remove from list of command line options

moving over to someone who's more likely to know this part of the code better.

Brian, this has the net effect of making it impossible to utilize the -splash
parameter with any MOZ_XUL_APP app.  Is this desired?

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 141491 [details] [diff] [review]
Hack to disable -splash and remove from list of command line options

There's a better way to fix this.  nsXULAppAPI has a field for whether the app
has a splash screen.  I had been using it for the default state of the splash
screen, but I'm thinking if it's set to false we should not allow the splash
screen to be enabled at all.

Comment 6

[Mike Connor [:mconnor]]

taking

Comment 7

[Mike Connor [:mconnor]]

pushing to 1.0beta, since this is of limited visibility.  minusing blocking0.9?
for the same reason

Comment 8

[Andrew Schultz]

worksforme with firefox 0.10.1

Comment 9

[Mike Connor [:mconnor]]

Seems to be WFM, please reopen if this can be reproduced on trunk nightlies.