231893 - progressListener.QueryInterface should not throw NS_NOINTERFACE for nsISupports

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[timeless]

Exception ``2147500034'' thrown from function anonymous(iid=XPComponent:{7}) in
<chrome://global/content/printPreviewProgress.js> line 108.
Stopped for thrown exception.

#0: function anonymous(iid=XPComponent:{7}) in
<chrome://global/content/printPreviewProgress.js> line 108

     QueryInterface : function(iid)
 -  104     {
 -  105      if (iid.equals(Components.interfaces.nsIWebProgressListener) ||
iid.equals(Components.interfaces.nsISupportsWeakReference))
 -  106       return this;
    107      
 -  108      throw Components.results.NS_NOINTERFACE;
    109     }

0001: iid.number
$[1] = [string] "{00000000-0000-0000-c000-000000000046}"

Comment 1

[Justin Wood (:Callek)]

Attachment: Fix

Timeless, would you do the r/sr?'s on this for me.

Comment 2

[Justin Wood (:Callek)]

Attachment: Toolkit Fix

The fix is also needed for toolkit

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 156668 [details] [diff] [review]
Toolkit Fix

This shouldnt be needed for aviary, though would not suffer if it was added
there

Comment 4

[timeless]

Comment on attachment 156667 [details] [diff] [review]
Fix

mozilla/xpfe/global/resources/content/printPreviewProgress.js	1.7

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 156668 [details] [diff] [review]
Toolkit Fix

<Callek> blake: I dont suppose I can get you to expand your sr+ to a r+sr+ on
Bug 231893 would you
<Callek> blake: thanks again in advance
<blake> yeah just make it both