mPrintPreviewObs.QueryInterface should not throw NS_NOINTERFACE for nsISupports

RESOLVED FIXED

Status

()

Core
Print Preview
--
trivial
RESOLVED FIXED
14 years ago
12 years ago

People

(Reporter: timeless, Assigned: Callek)

Tracking

({helpwanted})

Trunk
x86
Windows XP
helpwanted
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [reviewsPending])

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
Exception ``2147500034'' thrown from function anonymous(iid=XPComponent:{7}) in
<chrome://communicator/content/printPreviewBindings.xml> line 396.
Stopped for thrown exception.

#0: function anonymous(iid=XPComponent:{7}) in
<chrome://communicator/content/printPreviewBindings.xml> line 396


    391               QueryInterface : function(iid)
 -  392               {
 -  393                if (iid.equals(Components.interfaces.nsIObserver) ||
iid.equals(Components.interfaces.nsISupportsWeakReference))
 -  394                 return this;
    395      
 -  396                throw Components.results.NS_NOINTERFACE;
    397               }

0001: iid.number
$[1] = [string] "{00000000-0000-0000-c000-000000000046}"
Keywords: helpwanted
Whiteboard: [good first bug]
(Assignee)

Updated

14 years ago
Attachment #156665 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #156665 - Flags: review?(neil.parkwaycc.co.uk)

Comment 2

14 years ago
OK, I give up, I'd love to see the patch in action I can't find out where that
code gets called from.
(Assignee)

Comment 3

13 years ago
Neil, would this be a bad checkin anyway, I do not see why (personally) this
should not allow QI with nsISupports.

Timeless, what in particular prompted you to file this bug?

(Taking Bug so I dont loose this again)
Assignee: core.printing → 116057
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
Whiteboard: [good first bug] → [reviewsPending]
(Assignee)

Comment 4

13 years ago
When asking reporter (Timeless) if I should reso/invalid since we cannot find a
spot where this code is used.

<timeless> you're welcome to try to get the file deleted
<timeless> but the bug is valid from a code inspection perspective until such
time as the code no longer exists on HEAD in cvs :)

I'll file a follup bug later on about removing this file.

In the meantime I still suggest we commit this, since it allows QI to
nsISupports from the file, and it makes sense IMHO.

Comment 5

12 years ago
This code has been removed as part of Bug 311028.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Depends on: 311028
Resolution: --- → FIXED

Comment 6

12 years ago
Comment on attachment 156665 [details] [diff] [review]
Fix

Review no longer needed, bug fixed.
Attachment #156665 - Flags: superreview?(neil)
Attachment #156665 - Flags: review?(neil)
You need to log in before you can comment on or make changes to this bug.