231894 - mPrintPreviewObs.QueryInterface should not throw NS_NOINTERFACE for nsISupports

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[timeless]

Exception ``2147500034'' thrown from function anonymous(iid=XPComponent:{7}) in
<chrome://communicator/content/printPreviewBindings.xml> line 396.
Stopped for thrown exception.

#0: function anonymous(iid=XPComponent:{7}) in
<chrome://communicator/content/printPreviewBindings.xml> line 396


    391               QueryInterface : function(iid)
 -  392               {
 -  393                if (iid.equals(Components.interfaces.nsIObserver) ||
iid.equals(Components.interfaces.nsISupportsWeakReference))
 -  394                 return this;
    395      
 -  396                throw Components.results.NS_NOINTERFACE;
    397               }

0001: iid.number
$[1] = [string] "{00000000-0000-0000-c000-000000000046}"

Comment 1

[Justin Wood (:Callek)]

Attachment: Fix

Comment 2

[[e-mail]]

OK, I give up, I'd love to see the patch in action I can't find out where that
code gets called from.

Comment 3

[Justin Wood (:Callek)]

Neil, would this be a bad checkin anyway, I do not see why (personally) this
should not allow QI with nsISupports.

Timeless, what in particular prompted you to file this bug?

(Taking Bug so I dont loose this again)

Comment 4

[Justin Wood (:Callek)]

When asking reporter (Timeless) if I should reso/invalid since we cannot find a
spot where this code is used.

<timeless> you're welcome to try to get the file deleted
<timeless> but the bug is valid from a code inspection perspective until such
time as the code no longer exists on HEAD in cvs :)

I'll file a follup bug later on about removing this file.

In the meantime I still suggest we commit this, since it allows QI to
nsISupports from the file, and it makes sense IMHO.

Comment 5

[Frank Wein [:mcsmurf]]

This code has been removed as part of Bug 311028.

Comment 6

[Frank Wein [:mcsmurf]]

Comment on attachment 156665 [details] [diff] [review]
Fix

Review no longer needed, bug fixed.