Line graphs need more colours

RESOLVED FIXED in Bugzilla 2.18

Status

()

Bugzilla
Reporting/Charting
P2
normal
RESOLVED FIXED
14 years ago
5 years ago

People

(Reporter: gerv, Assigned: gerv)

Tracking

2.17.6
Bugzilla 2.18
Bug Flags:
approval +

Details

Attachments

(1 attachment)

It turns out that the GD::Graph has seven default colours for line graphs, then
it goes round again. New charts has made it obvious that this isn't enough.

The patch to fix this is simple - you just specify an array of colour names.

Gerv
Created attachment 139807 [details] [diff] [review]
Patch v.1

Let's have 16 colours. Any more, and they start looking too similar.

Gerv
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → Bugzilla 2.18
Comment on attachment 139807 [details] [diff] [review]
Patch v.1

Dave: playing with new charts on mecha convinced me we need this. Is it too
late for 2.17.7?

Gerv
Attachment #139807 - Flags: review?(justdave)
Whiteboard: [wanted for 2.17.7]?
Attachment #139807 - Flags: review?(justdave) → review+
Flags: approval+
Whiteboard: [wanted for 2.17.7]? → [wanted for 2.17.7]
Fixed.

Checking in template/en/default/reports/report-line.png.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/report-line.png.tmpl,v
 <--  report-line.png.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/reports/chart.png.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/chart.png.tmpl,v
 <--  chart.png.tmpl
new revision: 1.3; previous revision: 1.2
done

Gerv
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Whiteboard: [wanted for 2.17.7]
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.