232068 - security/ should use the newer nsIPrefService APIs instead of nsIPref

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Mikael Parknert]

nsIPref is deprecated and should be replaced by nsIPrefService with friends

Comment 1

[Mikael Parknert]

Attachment: patch to remove nsIPref

Comment 2

[Darin Fisher]

Comment on attachment 156989 [details] [diff] [review]
patch to remove nsIPref

>Index: security/manager/ssl/src/nsCRLManager.cpp

>+    nsCOMPtr<nsIPrefService> prefSvc = do_GetService(NS_PREFSERVICE_CONTRACTID,&rv);
>+    nsCOMPtr<nsIPrefBranch> pref = do_GetService(NS_PREFSERVICE_CONTRACTID,&rv);

Change one of these do_GetService calls into do_QueryInterface, or use
prefSvc->GetBranch, to get the default pref branch.  Not worth it to
go through the service manage twice to get back to the same underlying
object.


>Index: security/manager/ssl/src/nsNSSComponent.cpp

>+  else if (nsCRT::strcmp(aTopic, NS_PREFBRANCH_PREFCHANGE_TOPIC_ID) == 0) { 

I might have kept the PrefChanged function instead of adding
all this code inline.  But, I guess you are being consistent
with the other observer topics this function handles.  OK.


sr=darin

not sure if kaie is actively reviewing patches anymore.  if you don't
get a response from him, you might try asking someone else for a review.

Comment 3

[Wan-Teh Chang]

Comment on attachment 156989 [details] [diff] [review]
patch to remove nsIPref

Sorry, I'm not qualified to review this patch.
Darin, could you suggest someone familiar with
nsIPrefBranch and nsIPrefService to review this
patch?

Comment 4

[Mikael Parknert]

Comment on attachment 156989 [details] [diff] [review]
patch to remove nsIPref

not easy to find someone to review this. David do you think you are allowed
(and feel like it)?

Comment 5

[David :Bienvenu]

Comment on attachment 156989 [details] [diff] [review]
patch to remove nsIPref

I've r='d, but you still need a= from a module owner before this can be checked
in

Comment 6

[Mikael Parknert]

I'd like module owner approval on this patch

Comment 7

[John G. Myers]

moa=jgmyers

Comment 8

[Kenneth Herron]

Checking in boot/src/nsSecurityWarningDialogs.cpp;
/cvsroot/mozilla/security/manager/boot/src/nsSecurityWarningDialogs.cpp,v  <-- 
nsSecurityWarningDialogs.cpp
new revision: 1.10; previous revision: 1.9
done
Checking in boot/src/nsSecurityWarningDialogs.h;
/cvsroot/mozilla/security/manager/boot/src/nsSecurityWarningDialogs.h,v  <-- 
nsSecurityWarningDialogs.h
new revision: 1.3; previous revision: 1.2
done
Checking in pki/src/nsNSSDialogs.h;
/cvsroot/mozilla/security/manager/pki/src/nsNSSDialogs.h,v  <--  nsNSSDialogs.h
new revision: 1.17; previous revision: 1.16
done
Checking in ssl/src/nsCMSSecureMessage.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsCMSSecureMessage.cpp,v  <-- 
nsCMSSecureMessage.cpp
new revision: 1.9; previous revision: 1.8
done
Checking in ssl/src/nsCRLManager.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsCRLManager.cpp,v  <--  nsCRLManager.cpp
new revision: 1.11; previous revision: 1.10
done
Checking in ssl/src/nsNSSCertificateDB.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSCertificateDB.cpp,v  <-- 
nsNSSCertificateDB.cpp
new revision: 1.14; previous revision: 1.13
done
Checking in ssl/src/nsNSSComponent.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSComponent.cpp,v  <-- 
nsNSSComponent.cpp
new revision: 1.117; previous revision: 1.116
done
Checking in ssl/src/nsNSSComponent.h;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSComponent.h,v  <--  nsNSSComponent.h
new revision: 1.35; previous revision: 1.34
done
Checking in ssl/src/nsNSSIOLayer.cpp;
/cvsroot/mozilla/security/manager/ssl/src/nsNSSIOLayer.cpp,v  <--  nsNSSIOLayer.cpp
new revision: 1.94; previous revision: 1.93
done