232071 - Windows uninstaller cosmetic bug, \n is not escaped in folder name

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Alan Monroe]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

Dialog box reads:
"Not all files were uninstalled from the installation directory:
C:<newline>
et\Mozilla"
when it should read:
"Not all files were uninstalled from the installation directory:
c:\net\Mozilla"


Reproducible: Always

Steps to Reproduce:
Uninstall Mozilla from Add/Remove Programs control panel.
Actual Results:  
The backslash-n turned into a newline.

Expected Results:  
The backslash-n should remain part of the folder name.

Comment 1

[Alan Monroe]

Attachment: Screenshot of the newline problem

Comment 2

[Benjamin Smedberg]

This is caused by
http://lxr.mozilla.org/mozilla/source/xpinstall/wizard/windows/uninstall/extra.c#1888

We should switch the calls to _snprintf and ReplacePrivateProfileStrCR. Patch
forthcoming.

Comment 3

[Benjamin Smedberg]

Attachment: Switch _snprintf and ReplacePrivateProfileStrCR

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 139991 [details] [diff] [review]
Switch _snprintf and ReplacePrivateProfileStrCR

r/sr=[e-mail]

Comment 5

[Benjamin Smedberg]

checked in