232141 - No UI to change linkinfooter but it's still respected

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Gervase Markham [:gerv]]

The saved searches redesign eliminated linkinfooter along with the "footer"
prefs table. All queries were supposed to appear in the footer no matter what.

However, this doesn't appear to be the case. Oops.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This fixes the problem by removing the linkinfooter check in the footer. A
later, proper fix will remove the database column altogether, and all
references to it.

Gerv

Comment 2

[Gervase Markham [:gerv]]

Comment on attachment 139864 [details] [diff] [review]
Patch v.1

Myk/Dave?

Gerv

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 139864 [details] [diff] [review]
Patch v.1

Works, looks good.

Comment 4

[Bradley Baetz (:bbaetz)]

Umm... Why was that done? And if so, why set linkinfooter at all? There are some
queries that you don't want in the footer, necessarily, usch as little-used ones.

(When I go to query.cgi, I don't get an option to edit my saved queries, but
hey....)

Comment 5

[Gervase Markham [:gerv]]

See n.p.m.seamonkey for my post on this issue.

Gerv

Comment 6

[Stewart Gordon]

Why was the linkinfooter option removed?  I can't see any bug report related to it.

Comment 7

[Gervase Markham [:gerv]]

Stewart: see the newsgroup post for the background.

Gerv

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Gerv, ping; this needs checking in.

Comment 9

[Dave Miller [:justdave]]

no it doesn't.  The UI to change it is coming back.

Comment 10

[Gervase Markham [:gerv]]

Dave: I've written a patch over in bug 232176 to add a prefs panel for saved
searches. However, so we can get something out of the door for 2.17.7, version 1
doesn't allow changing of linkinfooter.

Would it be sensible to check this patch in (putting all links into the footer)
for that release, and reversing the change when the ability to manipulate
linkinfooter returns? Or are you going to hold 2.17.7 for a linkinfooter UI?

Gerv

Comment 11

[Dave Miller [:justdave]]

yeah, it would make sense.  Given that nobody complained about it in the two
months after 2.17.6 was out before it went live on b.m.o I think what's in
2.17.7 with regard to this probably won't be that important.  And even if
someone does complain, we're within striking distance of 2.18 release candidates
now, so as long as it works right before the release candidates are out, we'll
be okay.

Comment 12

[Gervase Markham [:gerv]]

Requesting approval for Patch v.1 based on comment 11.

Gerv

Comment 13

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/global/useful-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/useful-links.html.tmpl,v
 <--  useful-links.html.tmpl
new revision: 1.23; previous revision: 1.22
done

Gerv