232281 - outerHTML property in MsHtml.IHtmlElement is not implemented

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: ActiveX Wrapper, enhancement)

Description

[Alexandre Trémon]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

put_outerHTML and get_outerHTML are not implemented in CIEHtmlElement class

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Alexandre Trémon]

Attachment: put_outerHTML and get_outerHTML implementation

Comment 2

[Daniel Wang]

dupe of bug 92264?

Comment 3

[Alexandre Trémon]

bug 92264 is about the mozilla dom.
This is about the Mozilla Control which is intended to replace the IE activeX.

Comment 4

[Alexandre Trémon]

Attachment: previous attachment was not a diff

Comment 5

[Adam Lock]

Comment on attachment 139972 [details] [diff] [review]
previous attachment was not a diff

r=adamlock

Looks great to me

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 139972 [details] [diff] [review]
previous attachment was not a diff

 HRESULT STDMETHODCALLTYPE CIEHtmlElement::put_outerHTML(BSTR v)
 {
-    return E_NOTIMPL;
+	nsresult rv;
+	nsCOMPtr<nsIDOMDocument> domDoc;
...

This new code uses tabs for indentation, don't. Follow what's used in the rest
of the file.

 HRESULT STDMETHODCALLTYPE CIEHtmlElement::get_outerHTML(BSTR __RPC_FAR *p)
 {
...
+    }
+
+    *p = NULL;
+
+	nsresult rv;
+	nsAutoString outerHTML;

Mixed indentation, stick with spaces, don't use tabs.

sr=jst with the indentation fixed.

Comment 7

[Alexandre Trémon]

Attachment: Indentation fixed

Comment 8

[Adam Lock]

Fix is checked in, thanks Alexandre!