232338 - Footer is wider than the rest of the page

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect, P2)

Description

[Henrik Lynggaard Hansen]

After the recent "upgrade" of b.m.o I have now got 70 queries in the footer.
However the lines  breaks are such that the footer is wider than the rest of the
page.

I believe this to be caused by either the number of queries or the way the
"logout: <email addr>" formatting. I will attach a screenshot

Comment 1

[Henrik Lynggaard Hansen]

Attachment: Screenshot showing the problem

This shows the probem, as seen only half the footer is shown.
Problem is slightly bettered if I close the sidebar.

Comment 2

[Gervase Markham [:gerv]]

Henrik: could you do a Save Page As on a sample page with your footer, and
attach the resulting HTML?

Gerv

Comment 3

[Andrew Schultz]

The main problem is that the second column of the first table row in the footer
(everything from "New" to the email address) has HTML attribute nowrap="nowrap".

If you want to see this problem, just make your window ~730 pixels wide (as in
the screenshot).  But then, a lot of the web looks broken at 730 pixels...

Comment 4

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This patch rearranges the footer a bit so that it resizes more gracefully, and
is organised a bit more logically.

Gerv

Comment 5

[Gervase Markham [:gerv]]

Attachment: Screenshot of new footer

And here's what it looks like on my local test installation.

Gerv

Comment 6

[Gervase Markham [:gerv]]

Comment on attachment 140443 [details] [diff] [review]
Patch v.1

Myk: what do you think?

Gerv

Comment 7

[Myk Melez [:myk] [@mykmelez]]

linkinfooter is coming back per bug 232176, and nowrap has been around since
before b.m.o last upgraded, so removing this from the list of regressions and
making it dependent on 232176.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 140443 [details] [diff] [review]
Patch v.1

(UI review only)

Looks pretty good, but "prefs" should move to the first line so the average
user doesn't have to see the second line of "edit" links at all.

Comment 9

[Gervase Markham [:gerv]]

Myk: I actually think the extra line serves a useful purpose as a buffer between
the action links and the saved searches. Otherwise, the thing gets to be a bit
of a forest where it's hard to see what's wanted.

(To fix that for admins, actually, maybe we should style saved searches
differently...)

Gerv

Comment 10

[Gervase Markham [:gerv]]

Dave: this review request is still valid :-)

Gerv

Comment 11

[Dave Miller [:justdave]]

Comment on attachment 140443 [details] [diff] [review]
Patch v.1

I don't think SanityCheck belongs on the Edit line.

I also think all of the admin stuff should disappear out of the footer
entirely, and be replaced with a link to a page with an overview of the
administrative tools.  But that's a task for another bug. :)

Comment 12

[Gervase Markham [:gerv]]

Attachment: Patch v.2

Moves Sanity Check to the top line.

Gerv

Comment 13

[Dave Miller [:justdave]]

Comment on attachment 144213 [details] [diff] [review]
Patch v.2

This works for me :)

re-wraps nicely when you resize the window, too.  My only nit is that "My
Votes" gets split onto both lines if you resize the window just right.	I don't
think it's a big deal though and you're welcome to not fix it :)

Comment 14

[Christian Reis]

Comment on attachment 144213 [details] [diff] [review]
Patch v.2

>Index: template/en/default/global/useful-links.html.tmpl
>         [% IF user && Param('usevotes') %]
>           | <a href="votes.cgi?action=show_user">My Votes</a>

Yeah, missed an &nbsp; here.

Comment 15

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/global/useful-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/useful-links.html.tmpl,v
 <--  useful-links.html.tmpl
new revision: 1.24; previous revision: 1.23
done

Gerv