232441 - Error message not suggesting solution

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Vlad Dascalu]

Some people use the CVS version, and usually do a "cvs upgrade" from time to time.

However, a new param is also added in the CVS from time to time, and this causes
an error message if checksetup.pl is not launched after every cvs upgrade.

Unfortunately, the error message doesn't hint the user with the solution (re-run
checksetup.pl) in case new params get added.

Comment 1

[Vlad Dascalu]

Attachment: Patch version 1

Comment 2

[Vlad Dascalu]

Kiko, any chance to take a look at this? Every day that goes by with a "r?"
request pending results in a murdered kitten ;-)

Comment 3

[Vlad Dascalu]

Ok, just read about the Consave thing, so I think murdering kittens will be
delayed with a few hours to give you time to get up to speed. :-)

Comment 4

[Christian Reis]

Comment on attachment 140077 [details] [diff] [review]
Patch version 1

Sorry this took so long.

Add a period to the phrase before checking in, ok?

Comment 5

[Vlad Dascalu]

>> Add a period to the phrase before checking in, ok?

Sure thing. Thanks!

Comment 6

[Vlad Dascalu]

While investigating, I found out that die usually adds the line number on which
the error occured.

So without the dot it looks something like:

>> No value for param $param (try running checksetup.pl again) at line 34343

and with the dot it looks something like:

>> No value for param $param (try running checksetup.pl again). at line 34343

Talked with justdave about it and he said that no dot is better.

Too bad we can't add a dot at the end of the error message ;-)

Comment 7

[Vlad Dascalu]

Checking in Bugzilla/Config.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config.pm,v  <--  Config.pm
new revision: 1.19; previous revision: 1.18
done